FEATURE: DataObject scaffolding #20

unclecheese · 2016-12-12T23:52:49Z

Per #9

chillu

Wow, massive effort - looking great! Thanks for building in all the sanity checks around YAML configuration, and for creating an expressive system with PHP interfaces. Ran out of steam after 25 comments, will have a second pass tomorrow :)

chillu · 2016-12-14T08:28:02Z

README.md

@@ -243,6 +243,305 @@ This will create a new member with an email address,
 which you can pass in as query variables: `{"Email": "[email protected]"}`.
 It'll return the new `ID` property of the created member.

+## Scaffolding DataObjects into the Schema
+
+Making a DataObject accessible through the GraphQL API involves quite a bit of boilerplate. In the above example, we can see that creating endpoints for a query and a mutation requires creating three new classes, along with an update to the configuration, and we haven't even dealt with data relations yet. For applications that require a lot of business logic and specific functionality, an architecture like this affords the developer a lot of control, but for developers who just want to make a given model accessible through GraphQL with some basic Create, Read, Update, and Delete operations, scaffolding them can save a lot of time and reduce the clutter in your project.


Can you keep markdown line lengths to ~120 chars? Makes diffs easier to read

Why did you capitalise "Create" etc here?

I think I had just spent the previous eight hours defining ClassNames. ;-)

chillu · 2016-12-14T08:33:21Z

README.md

+
+**Code**:
+```php
+class Post extends DataObject implements ScaffoldingProvider {


Missing namespace for Post

Was trying to keep things brief, as that was already shown, but yeah, probably better to clarify.

That's fine, but from memory it was inconsistent - some of the example classes had the MyProject namespace

chillu · 2016-12-14T08:34:30Z

README.md

+    	$scaffolder->dataObject(Post::class)
+    		->addFields(['ID','Title','Content'])
+    		->query('readPosts', function() {
+    			return Post::get()->limit(10);


This will need to be updated once Will's pagination PR is merged in - might be follow-up work (not blocking this PR)

chillu · 2016-12-14T08:37:29Z

README.md

+      - My\Project\Post
+```
+
+### Scaffolding DataObjects through the Config layer


Feels a bit weird to describe the YAML-based confi here, without actually going into details ("scaffolding goes here"), then switching back to the provider-based docs. I'd prefer to start with YAML scaffolding, since that's what we'd assume is more frequently used?

OK, will reverse those two paragraphs.

chillu · 2016-12-14T08:38:04Z

README.md

+    		])
+    		->setResolver(function($obj, $args) {
+    			$post = Post::get()->byID($args['ID']);
+    			$post->Title = $args['NewTitle'];


Needs canEdit() checks

chillu · 2016-12-14T09:48:45Z

src/Scaffolding/Scaffolders/DataObjectScaffolder.php

+
+        foreach ($fields as $fieldName) {
+            $result = $instance->obj($fieldName);
+            if ($result instanceof DBField) {


How do we deal with getters? Force $casting? Then we should throw an exception if the result is not an instance of DBField

Well, we could try to be smart about it, seeing as there are only four GraphQL field types.

Have updated to:

foreach ($fields as $fieldName) { $result = $instance->obj($fieldName); if ($result instanceof DBField) { $typeName = $result->config()->graphql_type; $fieldMap[$fieldName] = (new TypeParser($typeName))->toArray(); } else if(is_bool($result)) { $fieldMap[$fieldName] = ['type' => Type::boolean()]; } else if(is_int($result)) { $fieldMap[$fieldName] = ['type' => Type::int()]; } else if(is_float($result)) { $fieldMap[$fieldName] = ['type' => Type::float()]; } else { $fieldMap[$fieldName] = ['type' => Type::string()]; } }

chillu · 2016-12-14T09:51:39Z

src/Scaffolding/Scaffolders/DeleteOperationScaffolder.php

+        );
+
+        $this->setResolver(function ($object, array $args, $context, $info) {
+            if (singleton($this->dataObjectName)->canDelete()) {


Needs to be called on the actual object, not the singleton

chillu · 2016-12-14T09:52:40Z

src/Scaffolding/Scaffolders/DeleteOperationScaffolder.php

+    public function __construct($dataObjectName)
+    {
+        $this->dataObjectName = $dataObjectName;
+        $this->args = [


Could we make this accept a List of IDs by default? It would help with the current case of asset admin batch deletes, and my gut feel is that it's going to be a common requirement in web apps

chillu · 2016-12-14T09:53:08Z

src/Scaffolding/Scaffolders/DeleteOperationScaffolder.php

+                $obj = DataList::create($this->dataObjectName)
+                    ->byID($args['ID']);
+
+                if ($obj) {


Should throw an exception if the object can't be found

chillu · 2016-12-14T09:55:24Z

src/Scaffolding/Scaffolders/GraphQLScaffolder.php

+                                $ops[] = constant($constStr);
+                            } else {
+                                throw new \Exception(
+                                    "Invalid operation: $op"


Mention the context here to make it debuggable (e.g. $dataObjectName)

codecov-io · 2016-12-18T09:20:04Z

Codecov Report

Merging #20 into master will increase coverage by 3.23%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   87.27%   90.51%   +3.23%     
==========================================
  Files          18       36      +18     
  Lines         566     1402     +836     
==========================================
+ Hits          494     1269     +775     
- Misses         72      133      +61

Impacted Files	Coverage Δ
tests/Fake/FakeResolver.php	`0% <ø> (ø)`
src/Scaffolding/Scaffolders/QueryScaffolder.php	`100% <100%> (ø)`
tests/Fake/RestrictedDataObjectFake.php	`100% <100%> (ø)`
src/Scaffolding/Traits/Chainable.php	`100% <100%> (ø)`
src/Scaffolding/Scaffolders/CRUD/Delete.php	`100% <100%> (ø)`
tests/Fake/MutationCreatorFake.php	`100% <100%> (ø)`	✅
tests/Fake/PaginatedQueryFake.php	`72.72% <100%> (ø)`	✅
src/Scaffolding/Scaffolders/CRUD/Create.php	`100% <100%> (ø)`
src/Scaffolding/Scaffolders/MutationScaffolder.php	`100% <100%> (ø)`
src/Scaffolding/Scaffolders/ArgumentScaffolder.php	`100% <100%> (ø)`
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 637f634...fd5d41f. Read the comment docs.

robbieaverill · 2017-01-06T09:33:23Z

examples/code/CommentsResolver.php

+		}
+
+		return $comments;
+    }


Daaaaaamn! That's much easier to digest!

chillu · 2017-01-10T08:41:18Z

src/Scaffolding/Scaffolders/GraphQLScaffolder.php

+ * The entry point for a GraphQL scaffolding definition. Holds DataObject type definitions,
+ * and their nested Mutation/Query definitions.
+ */
+class GraphQLScaffolder implements ManagerMutatorInterface


Since this is in the SilverStripe\GraphQL namespace the class should be called Scaffolder instead of GraphQLScaffolder - it's redundant information. Given this will be frequently used to reference constants, a shorter class name is good news as well

Yeah, I thought about that, but there's also DataObjectScaffolder, QueryScaffolder, OperationScaffolder, etc. I'm not sure I'm comfortable with it being Scaffolder in that context, but I agree that GraphQL is redundant.

SchemaScaffolder?

Yeah SchemaScaffolder works for me.

chillu · 2017-01-10T08:52:24Z

tests/ScaffoldingTest.php

+namespace SilverStripe\GraphQL;
+
+use SilverStripe\Dev\SapphireTest;
+// use GraphQL\Type\Definition\Type;


Tests need to be commented in again

These were written before a massive change in architecture and API, so I commented them out just to get this to a reviewable state. I'm working on the new test suite right now.

chillu · 2017-01-10T09:01:21Z

README.md

+For these examples, we'll imagine we have the following model:
+
+```php
+namespace MyProject\GraphQL;


ORM model classes shouldn't live in a MyProject\GraphQL namespace - in and of themselves, they have nothing to do with GraphQL, and it'll tend to confuse devs (by wrongly assuming there's something special about these models). I'd suggest putting them in a MyProject only (rather than a more verbose MyProject\Model\

OK, have changed the namespace to MyProject for everything.

chillu · 2017-01-10T09:03:38Z

README.md

+
+**Via YAML**:
+```
+SilverStripe\GraphQL:


Needs yaml markdown syntax marking

chillu · 2017-01-10T09:09:30Z

README.md

+          fields: [ID, Title, Content]
+          operations:
+            read: true
+            create: true


Doesn't have update: true, yet has an updatePost() query example below

Have changed the example to CreatePost instead

chillu · 2017-01-10T09:33:59Z

README.md

+    	Content
+  }
+}
+```


At this point you probably should describe how the readPosts naming was generated (automatically inferred from singular_name and plural_name)

Have added an explanation

chillu · 2017-01-10T09:36:47Z

README.md

+          operations:
+            read:
+              args:
+                StartingWith: String


StartingWith is a bit of a confusing argument example, particularly as a slight variation from the StartsWith ORM filter. Is there a reason you didn't just use Title as the arg name and perform a partial match?

OK, have changed to PartialMatch.

chillu · 2017-01-10T09:38:00Z

README.md

+    				'StartingWith' => 'String'
+    			])
+        		->setResolver(function($obj, $args) {
+        			$list = Post::get();


We probably shouldn't have any examples without canView() checks, I'd add at least a PHP comment like // ... canView checks. It's too easy for devs to assume that scaffolded resolvers will magically take care of this.

Have added a simple canView($context['currentMember']) check.

chillu · 2017-01-10T09:42:29Z

src/Scaffolding/Scaffolders/DataObjectScaffolder.php

+            return $this;
+        }
+
+        if ($config['operations'] === '*') {


The README mentions all, but the code only accepts *.

chillu · 2017-01-10T09:43:11Z

README.md

+        operations: [CREATE, READ, UPDATE, DELETE]
+```
+
+> As shorthand, the expression `[CREATE, READ, UPDATE, DELETE]` can also be expressed as `operations: all`.


My point is: Why isn't there a GraphQLScaffolder::ALL constant as well? Constants are a way to communicate type strictness and avoid misspelling. Also, the README mentions all, but the code only accepts *. Can we just make this GraphQLScaffolder::ALL?

chillu

Another slew of nitpicks! ;)

chillu · 2017-01-10T10:17:37Z

As a general note, all GraphQL fields should start lowercase, to distinguish them from types starting with uppercase. This clashes with our SilverStripe conventions (DataObject properties start with uppercase). I've written https://github.com/silverstripe/silverstripe-graphql/blob/master/src/Util/CaseInsensitiveFieldAccessor.php for this purpose. Doesn't necessarily need to be solved in this PR, but we need to address it soon (for query args and query/type fields)

chillu · 2017-01-10T09:58:14Z

src/Scaffolding/Scaffolders/OperationScaffolder.php

+            if (is_subclass_of($resolver, ResolverInterface::class)) {
+                $this->resolver = Injector::inst()->create($resolver);
+            } else {
+                var_dump($resolver);


chillu · 2017-01-10T10:10:23Z

src/Scaffolding/Util/TypeParser.php

+     */
+    public function __construct($rawArg)
+    {
+        if (!preg_match('/^([A-Za-z]+)(!?)(\s*=\s*(.*))?/', $rawArg, $matches)) {


Protip: You can use a non-capturing group in regexes to avoid leaving out $matches[3] here: ^([A-Za-z]+)(!?)(?:\s*=\s*(.*))?

Ah, I had been wondering if that was possible. Thanks.

chillu · 2017-01-10T10:14:17Z

src/Scaffolding/Scaffolders/CRUD/Create.php

+
+        // Todo: this is totally half baked
+        $this->setResolver(function ($object, array $args, $context, $info) {
+            if (singleton($this->dataObjectClass)->canCreate()) {


All can*() checks should pass in $context['currentMember'] - an attempt to decrease the dependence of globals throughout the framework (Session dependency in DataObject::can*()). At the moment it's just future proofing, but it's pretty much always clearer to pass in context explicitly

chillu · 2017-01-10T10:21:14Z

README.md

+{
+    public function resolve($object, $args, $context, $info)
+    {
+		$post = Post::get()->byID($args['ID']);


Needs canEdit() check

All the CRUD operations now have permission checks.

chillu · 2017-01-10T10:22:26Z

README.md

+				->setResolver(MyResolver::class)
+				->end();
+```
+Or...


I'd just add the second variation as an inline comment on the first code example, for brevity's sake

chillu · 2017-01-10T10:23:23Z

README.md

+```
+
+```
+mutation UpdatePost($ID: ID!, $Input: PostUpdateInputType!)


Mention somewhere around here that permission constraints are enforced by the built-in resolvers

chillu · 2017-01-10T10:29:09Z

README.md

+
+**GraphQL**
+```
+mutation updatePostTitle(ID: 123, NewTitle: 'Foo') {


Missing $ in args

chillu · 2017-01-10T10:30:27Z

README.md

+}
+
+mutation createRedirectorPage {
+	RedirectorPageCreateInputType


Are you missing those input types in your type list above?

Yes. Have added them.

chillu · 2017-01-10T10:33:27Z

src/Scaffolding/Scaffolders/CRUD/Read.php

+        parent::__construct($operationName, $this->typeName());
+
+        $this->setResolver(function ($object, array $args, $context, $info) {
+            $list = DataList::create($this->dataObjectClass);


Shouldn't this filter by canView()?

Yeah, but you have to use filterByCallback if you want to be thorough. Otherwise, a simple check against a singleton could work.

This callback would need to comply with the OperationResolver interface right? $info would need a ResolveInfo type hint

Mmm... If you passed it a named class, or an instance, it has to implement OperationResolver, but AFAIK, there's no way to enforce an argument signature on a closure.

robbieaverill · 2017-01-11T20:09:45Z

src/Manager.php

 use GraphQL\Type\Definition\ObjectType;
 use GraphQL\Error;
 use GraphQL\Type\Definition\Type;
-use SilverStripe\Security\Member;


Hey Aaron - you'll need this back in again, it's used for the member methods at the bottom - I think this is why your tests are failing ATM

Have replaced this.

tractorcow · 2017-01-31T01:02:07Z

Some weird rebasing going on here. :P

tractorcow

I've reviewed this from a code-style and ORM usage perspective. I'm going to assume that @chillu has / will covered the functional review and is happy with the graphql API usage.

tractorcow · 2017-01-31T01:03:44Z

examples/_config/config.yml

@@ -12,3 +12,46 @@ SilverStripe\GraphQL:
  authenticators:
    - class: SilverStripe\GraphQL\Auth\BasicAuthAuthenticator
      priority: 10
+    scaffolding_providers:
+     - My\Project\Post


What is the significance of My\Project\Post?

This is in the examples/ directory, so this is just an example of how you would set up your config with registered scaffolding providers.

tractorcow · 2017-01-31T01:08:27Z

src/FieldCreator.php

@@ -82,7 +82,7 @@ public function getAttributes()
            $attributes['type'] = $type;
        }

-        $resolver = $this->getResolver();
+        $resolver = $this->getResolver();        


Side note: We need to run phpcbf over this project to fix all extraneous whitespaces and formatting errors.

tractorcow · 2017-01-31T01:09:52Z

src/GraphiQLController.php

+	/**
+	 * @var string
+	 */
+	protected $template = 'GraphiQL';


From 4.0 onwards best practice is to namespace templates, please. :)

Even better, just make the template name GrahpiQLController.ss, put it in the correct folder (templates\SilverStripe\GraphQL), and you don't need to declare the config at all.

Yeah, this feature was supposed to be deleted in this 4e3a325 but at some point a rebase got stuffed.

tractorcow · 2017-01-31T01:10:29Z

src/InterfaceTypeCreator.php

@@ -2,28 +2,18 @@

 namespace SilverStripe\GraphQL;

-use GraphQL\Type\Definition\InterfaceType;
+use GraphQL\Type\Definition\InterfaceType as BaseInterfaceType;


Alias isn't necessary here.

tractorcow · 2017-01-31T01:11:39Z

src/Manager.php

-     * Execute an arbitrary operation (mutation / query) on this schema
+     * @param string $query
+     * @param array  $params
+     * @param null   $schema


invalid phpdoc; Should be at least one non-null arg type.

Also, phpdoc description getting deleted.

tractorcow · 2017-01-31T02:01:54Z

src/Scaffolding/Scaffolders/OperationScaffolder.php

+    /**
+     * OperationScaffolder constructor.
+     *
+     * @param null $operationName


Please use a non-null param type descriptor (and elsewhere).

tractorcow · 2017-01-31T02:03:08Z

src/Scaffolding/Scaffolders/OperationScaffolder.php

+        	}
+        	foreach($config['args'] as $argName => $argData) {
+        		if(is_array($argData)) {
+					if(!isset($argData['type'])) {


Indentation is a bit weird.

tractorcow · 2017-01-31T02:08:06Z

src/Scaffolding/Scaffolders/SchemaScaffolder.php

+     * @param string $class
+     * @param null   $resolver
+     *
+     * @return bool|QueryScaffolder


It doesn't seem to return any bool does it?

tractorcow · 2017-01-31T02:10:17Z

src/Scaffolding/Util/ScaffoldingUtil.php

+     */
+    public static function typeNameForDataObject($class)
+    {
+        $typeName = Config::inst()->get($class, 'table_name', Config::UNINHERITED) ?:


tractorcow · 2017-01-31T02:12:09Z

templates/GraphiQL.ss

@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html lang="en">


As discussed earlier, please move to namespaced folder matching the controller FQN.

This shouldn't even be here. It's an artefact of the bad rebasing you were referring to.

Required to make scaffolding work cleanly. See #20 (comment)

Constructor args on DataObject don’t call setters

chillu · 2017-02-02T10:17:28Z

examples/code/Post.php

+			->end()
+			->type('Page')
+			->addFields(['BackwardsTitle'])
+			->end();


Would be good to have this indented to retain some sanity ;)

sminnee · 2017-02-02T19:55:31Z

Woohoo! Great to see this merged

…der-tweaks Update code for upgrader

…ocus-transform Add an autoFocus property to the Form

unclecheese force-pushed the feature/scaffolding branch from 3f70b60 to a7356db Compare December 13, 2016 08:21

chillu requested changes Dec 14, 2016

View reviewed changes

unclecheese force-pushed the feature/scaffolding branch from 4b2d6e4 to 5fb77fd Compare December 15, 2016 08:24

unclecheese force-pushed the feature/scaffolding branch 2 times, most recently from d05717b to ea08f67 Compare December 23, 2016 03:07

robbieaverill reviewed Jan 6, 2017

View reviewed changes

examples/code/CommentsResolver.php

}

return $comments;

}

Copy link

Contributor

robbieaverill Jan 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daaaaaamn! That's much easier to digest!

chillu reviewed Jan 10, 2017

View reviewed changes

chillu requested changes Jan 10, 2017

View reviewed changes

chillu reviewed Jan 10, 2017

View reviewed changes

unclecheese force-pushed the feature/scaffolding branch 2 times, most recently from 08a9573 to db22c0d Compare January 11, 2017 01:23

robbieaverill reviewed Jan 11, 2017

View reviewed changes

unclecheese force-pushed the feature/scaffolding branch 2 times, most recently from 40ea1f9 to e4be8ff Compare January 14, 2017 20:19

chillu force-pushed the feature/scaffolding branch from e4be8ff to 406b770 Compare January 15, 2017 09:38

unclecheese force-pushed the feature/scaffolding branch from 406b770 to 644644f Compare January 18, 2017 00:01

chillu added this to the CMS 4.0.0-alpha5 milestone Jan 18, 2017

unclecheese force-pushed the feature/scaffolding branch from b987bc0 to baf8b93 Compare January 20, 2017 02:27

unclecheese force-pushed the master branch from 83ae9b8 to 637f634 Compare January 20, 2017 02:36

unclecheese force-pushed the feature/scaffolding branch from baf8b93 to d8af239 Compare January 20, 2017 02:37

tractorcow suggested changes Jan 31, 2017

View reviewed changes

Uncle Cheese added 5 commits January 31, 2017 20:05

FEATURE: DataObject scaffolding

38535d8

Fix phpunit.xml syntax

ab44175

README updates for scaffolding docs

3b73495

Remove @Package declarations

81e0809

Change $dataObjectName to $dataObjectClass

51c0781

Uncle Cheese added 4 commits January 31, 2017 20:38

BUGFIX: incorrect array shape for CRUD args

f49759c

BUGFIX: Malformed input type fields

aeed6c7

PSR2 formatting

4716387

Code formatting for tests

62cdf22

unclecheese force-pushed the feature/scaffolding branch from 0183b6d to 62cdf22 Compare January 31, 2017 07:41

Uncle Cheese and others added 16 commits January 31, 2017 21:07

Clean up rebasing issues

d018593

docblock revisions

1066eb7

Rename Configurable to ConfigurationApplier

7672e24

More docblock cleanup

1977943

Update example code to use DateTime

d6eb733

Add new fake redirector page so tests pass without CMS

8296a23

Build shim classes for Page, SiteTree

1456d5b

API Separate connection() to get/create

17dc73e

Required to make scaffolding work cleanly. See #20 (comment)

Use DB transaction for multi delete

c08bda7

Fix examples

06ff0b2

Fix example $db declaration

198127c

Fix example whitespace

641213b

Use DO->update() for create

7047fba

Constructor args on DataObject don’t call setters

Use DataObjectSchema

3e981b7

More example class reference fixes

7d41007

Correct use of currentUser context

fd5d41f

chillu reviewed Feb 2, 2017

View reviewed changes

chillu approved these changes Feb 2, 2017

View reviewed changes

chillu merged commit 3e77ff4 into master Feb 2, 2017

chillu deleted the feature/scaffolding branch February 2, 2017 10:29

This was referenced Feb 2, 2017

Scaffold input type inheritance #23

Closed

Scaffold object type inheritance #22

Closed

unclecheese pushed a commit to open-sausages/silverstripe-graphql that referenced this pull request Jan 9, 2018

Merge pull request silverstripe#20 from open-sausages/pulls/4.0/upgra…

4ebff9e

…der-tweaks Update code for upgrader

unclecheese pushed a commit to unclecheese/silverstripe-graphql that referenced this pull request Jan 27, 2021

Merge pull request silverstripe#20 from open-sausages/pulls/4.0/autof…

65fc27e

…ocus-transform Add an autoFocus property to the Form

FEATURE: DataObject scaffolding #20

FEATURE: DataObject scaffolding #20

Conversation

unclecheese commented Dec 12, 2016

chillu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unclecheese Dec 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Dec 18, 2016 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unclecheese Jan 10, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unclecheese Jan 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chillu left a comment

Choose a reason for hiding this comment

chillu commented Jan 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tractorcow commented Jan 31, 2017

tractorcow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unclecheese Dec 15, 2016 •

edited

Loading

codecov-io commented Dec 18, 2016 •

edited

Loading

unclecheese Jan 10, 2017 •

edited

Loading

unclecheese Jan 12, 2017 •

edited

Loading