Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Update README.md for CMS 5 #347

Merged
merged 1 commit into from
Apr 21, 2023
Merged

DOC Update README.md for CMS 5 #347

merged 1 commit into from
Apr 21, 2023

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Apr 19, 2023
Closed
5 tasks
@GuySartorelli GuySartorelli force-pushed the pulls/4.0/cms5-readme branch from ffeb0c6 to 477c48b Compare April 19, 2023 05:40
sabina-talipova
sabina-talipova reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this statement still actual?

silverstripe-fulltextsearch/README.md

Line 7 in 477c48b

Compatible with PHP 7.2

@GuySartorelli
Copy link
Member Author

Nope, I'll fix that.
Also FYI github has a new feature to add a comment to a file, which will let me reply in a comment chain similarly to when you comment on a specific line.

@GuySartorelli GuySartorelli force-pushed the pulls/4.0/cms5-readme branch from 477c48b to 6245ec9 Compare April 21, 2023 03:47
sabina-talipova
sabina-talipova approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@sabina-talipova sabina-talipova merged commit b1ad41d into silverstripe:4.0 Apr 21, 2023
@sabina-talipova sabina-talipova deleted the pulls/4.0/cms5-readme branch April 21, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabina-talipova sabina-talipova sabina-talipova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @sabina-talipova