ENH Make ElementalContentExtension MyPage a required field #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
emteknetnz
force-pushed
the
pulls/1/non-inline-behat
branch
2 times, most recently
from
d690b4c to
86fd8b3
Compare
emteknetnz
commented
Apr 30, 2024
| @@ -6,7 +6,7 @@ | |||
| use SilverStripe\Security\DefaultAdminService; | |||
| use SilverStripe\Security\Member; | |||
|
|
|||
| if (!class_exists(RegistryPage::class)) { | |||
| if (class_exists(RegistryPage::class)) { | |||
There was a problem hiding this comment.
This was clearly wrong, it broke my first attempt at doing a shared ci run
emteknetnz
force-pushed
the
pulls/1/non-inline-behat
branch
2 times, most recently
from
6daf6f3 to
e9baa43
Compare
GuySartorelli
requested changes
May 3, 2024
emteknetnz
force-pushed
the
pulls/1/non-inline-behat
branch
from
e9baa43 to
433028a
Compare
emteknetnz
changed the title
|
Done |
GuySartorelli
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-elemental#1178