Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Add custom validator for test cases #158

Merged
merged 1 commit into from
Nov 12, 2023
Merged

MNT Add custom validator for test cases #158

merged 1 commit into from
Nov 12, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Nov 2, 2023
Closed
GuySartorelli
GuySartorelli reviewed Nov 2, 2023
View reviewed changes
code/Company.php Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli reviewed Nov 2, 2023
View reviewed changes
code/Employee.php Outdated Show resolved Hide resolved
@sabina-talipova
Copy link
Contributor Author

All failed tests are not related to PRs.
https://github.com/sabina-talipova/recipe-kitchen-sink/actions/runs/6792074969

@sabina-talipova sabina-talipova force-pushed the pulls/0.4/toast-msg-gridfield branch from 32c7dfb to 32b9b49 Compare November 8, 2023 22:29
@sabina-talipova sabina-talipova force-pushed the pulls/0.4/toast-msg-gridfield branch from 32b9b49 to 2483724 Compare November 9, 2023 02:57
GuySartorelli
GuySartorelli approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when all other PRs are ready.

@sabina-talipova sabina-talipova force-pushed the pulls/0.4/toast-msg-gridfield branch 2 times, most recently from 74b06c1 to 62e771e Compare November 9, 2023 23:06
@sabina-talipova sabina-talipova force-pushed the pulls/0.4/toast-msg-gridfield branch from 62e771e to 3f03425 Compare November 9, 2023 23:38
GuySartorelli
GuySartorelli approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as discussed I'll open a separate card to fix toasts for model-level validation

@GuySartorelli GuySartorelli merged commit 6637e88 into silverstripe:0.4 Nov 12, 2023
@GuySartorelli GuySartorelli deleted the pulls/0.4/toast-msg-gridfield branch November 12, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli