Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Extracting logic for canX from Company and Employee #122

Merged

Conversation

sabina-talipova
Copy link
Contributor

Description

  • New DataObject Extension to provide canX permissions to extended DataObject in frameworktest module
  • Append Extension to Company and Employee classes.

Parent issue

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any behat tests that were merged which expect the COMPANY_EDIT permission?

@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Sep 13, 2022

Are there any behat tests that were merged which expect the COMPANY_EDIT permission?

I've replaced code in Company class with generic extension to apply it in few DataObjects.

@GuySartorelli
Copy link
Member

I've replaced code in Company class with generic extension to apply it in few DataObjects.

That's exactly why I'm asking this question. I know that there were some PRs that used the old permission which is now being removed. My question is whether any of those PRs were merged (and therefore we would need new PRs to change those to use the new generic permission)

@sabina-talipova sabina-talipova force-pushed the pulls/4/review-behat-tests branch from db2a9fb to 8b9a80e Compare September 13, 2022 02:21
@sabina-talipova
Copy link
Contributor Author

  • Review behat tests to avoid using admin users silverstripe-behat-extension#220

No. There are only two Behat test cases in silverstripe-admin and silverstripe-asset-admin

@GuySartorelli GuySartorelli merged commit da63f28 into silverstripe:0.4 Sep 14, 2022
@GuySartorelli GuySartorelli deleted the pulls/4/review-behat-tests branch September 14, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants