ENH Add permissions for Content Editor

[sabina-talipova]

Description

Add $required_permission_codes for 'CMS_ACCESS_CMSMain' in ElementalBehatTestAdmin class to support new changes in behat tests for Elemental module.

Parent issue

• Review behat tests to avoid using admin users silverstripe-behat-extension#220

[GuySartorelli]

Instead of creating a new permission, just use ElementalBehatTestAdmin::getRequiredPermissions() instead

Suggested change

	return Permission::check('ELEMENTAL_EDIT', 'any', $member);
	return Permission::check(ElementalBehatTestAdmin::getRequiredPermissions(), 'any', $member);

You'll need to update the others and remove providePermissions() as well.

[sabina-talipova]

DONE

[GuySartorelli]

There's no need for this - LeftAndMain::providePermissions() creates a new permission for each ModelAdmin subclass automagically.
The correct permission code to use in behat tests for this admin section is CMS_ACCESS_SilverStripe\FrameworkTest\Elemental\Admin\ElementalBehatTestAdmin

Using this means we're also indirectly testing that the LeftAndMain::providePermissions() and LeftAndMain::getRequiredPermission() logic works as expected.

[sabina-talipova]

I'll leave private static $required_permission_codes = 'ELEMENTAL_EDIT' instead of using CMS_ACCESS_SilverStripe\FrameworkTest\Elemental\Admin\ElementalBehatTestAdmin, since it's more readable in the behat test

[sabina-talipova]

Probably, I'll rename it to give it more obvious meaning.

[GuySartorelli]

When testing locally, I can't create a new elemental block on an ElementalBehatTestObject if I only have ELEMENTAL_DATAOBJECT_EDIT permissions. Is that expected?