Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add file status icons to change log #9522

Merged

Conversation

emteknetnz
Copy link
Member

@brynwhyman
Copy link
Contributor

If we can add screenshots (which I think we can) I think that would be a helpful addition!

@emteknetnz emteknetnz force-pushed the pulls/4/file-manager-icons branch from 6afb308 to b8cef11 Compare May 28, 2020 02:59
@emteknetnz emteknetnz force-pushed the pulls/4/file-manager-icons branch from b8cef11 to fef8fca Compare May 28, 2020 03:05
@emteknetnz
Copy link
Member Author

emteknetnz commented May 28, 2020

@brynwhyman have added an image, it won't show in the markdown file until it is merged

For now, you can see this file at
https://raw.githubusercontent.com/creative-commoners/silverstripe-framework/pulls/4/file-manager-icons/docs/en/04_Changelogs/_images/file-status-icons.png

Will display like this:

image

@emteknetnz emteknetnz merged commit 44776a0 into silverstripe:4 May 28, 2020
@emteknetnz emteknetnz deleted the pulls/4/file-manager-icons branch May 28, 2020 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants