Opt-out of in-memory caching factory #9045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
In-memory caches are typically more resource constrained (number of items and storage space). Give cache consumers an opt-out if they are expecting to create large caches with long lifetimes. Use case: silverstripe/silverstripe-assets#282
maxime-rainville
force-pushed
the
pulls/4.4/in-memory-cache-opt-out
branch
from
76d0c50 to
8324235
Compare
maxime-rainville
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
Tested locally. I enabled APCu on my PHP install to make sure that part was working correctly.
I thought about adding some unit test, but the end result is so dependant on what your PHP set up is, that it would be somewhat pointless to try to test it.
I amend the commit message so it gets picked up when generating the change logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-memory caches are typically more resource constrained (number of items and storage space).
Give cache consumers an opt-out if they are expecting to create large caches with long lifetimes.
Use case: silverstripe/silverstripe-assets#282
Note that I've purposely left this undocumented, it's a system internal that we're using in one place for core at the moment.
Parent issue