Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With config functionality added. #9005

Closed
wants to merge 1 commit into from
Closed

With config functionality added. #9005

wants to merge 1 commit into from

Conversation

mfendeksilverstripe
Copy link
Contributor

New feature:

  • withConfig - a callback that allows to safely manipulate configuration
  • very useful for unit tests

@robbieaverill
Copy link
Contributor

Quick note: as a new feature this will need to target the 4 branch

@mfendeksilverstripe mfendeksilverstripe changed the base branch from 4.3 to 4 May 26, 2019 23:04
@mfendeksilverstripe mfendeksilverstripe changed the base branch from 4 to 4.3 May 26, 2019 23:04
@mfendeksilverstripe
Copy link
Contributor Author

Replaced by #9011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects/v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfendeksilverstripe @robbieaverill