NEW Add new execmetric debur URL parameter to print out exection time and peak memory usage #8733
Conversation
maxime-rainville
force-pushed
the
pulls/4/add-exectmetric-url-debug-param
branch
from
2ab31b8 to
70a38a0
Compare
docs/en/02_Developer_Guides/07_Debugging/02_URL_Variable_Tools.md
Outdated
Show resolved
Hide resolved
… and peak memory usage
maxime-rainville
force-pushed
the
pulls/4/add-exectmetric-url-debug-param
branch
from
66709ef to
c4bf06f
Compare
|
I witch to using middlewares as suggested by @ScopeyNZ. Seems to be working pretty well. A minor concern is the order in which the middle ware get added will potentially impact the actual memory usage. There's not really a way of giving those a priority right now. Probably not a big deal, because you would hope your middlewares are pretty light weight any way. |
| * Get the peak memory usage formatted has a string and a meaningful unit. | ||
| * @return string | ||
| */ | ||
| private function formatPeakMemoryUsage() |
There was a problem hiding this comment.
We prefer protected over private
There was a problem hiding this comment.
Those 3 methods are implementations details and are not meant to be reuse. In theory, I could have implemented all of those directly in process, but I wanted to split them out for readability. In this context, I don't think it's worthwhile increasing our public API surface.
| { | ||
| /** | ||
| * @inheritdoc | ||
| */ |
There was a problem hiding this comment.
This is equivalent to not having a doc block at all
| use SilverStripe\Dev\Debug; | ||
|
|
||
| /** | ||
| * Secures requests by only allowing a whitelist of Host values |
There was a problem hiding this comment.
Is that really what this middleware does?
There was a problem hiding this comment.
Oh whoops that's a retrospective review. Explains why I didn't see all the options when submitting it.
There was a problem hiding this comment.
🤦♂️ I copied over one of the other files. Forgot to update the comment.
There was a problem hiding this comment.
I'll do a follow up PR.
This is a quick something I put together to help debug #8664
Basically, if you add
execmetricsas a URL Get parameter, you'll get a print out of how long the request took and the peak memory usage.Figure it might be helpful going forward.