Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for null values in template lookups #8456

Merged
merged 3 commits into from
Oct 12, 2018
Merged

Add support for null values in template lookups #8456

merged 3 commits into from
Oct 12, 2018

Conversation

kinglozzer
Copy link
Member

No description provided.

sminnee
sminnee approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@sminnee sminnee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this looks like we've covered the changes in the necessary tests - looks good to me, but I'd appreciate 1 more reviewer.

@sminnee
Copy link
Member

sminnee commented Oct 10, 2018

Should this be master or 4, @kinglozzer? I don't think it's breaking?

@kinglozzer
Copy link
Member Author

@sminnee it builds upon #8152, which was merged into master. IIRC I took that decision mainly to “play it safe”, though it may be possible to backport one or both of these PRs to 4... I definitely don’t think SSViewer_DataPresenter counts as part of our public API 😉

@sminnee
Copy link
Member

sminnee commented Oct 12, 2018

OK then I'll merge to master for now.

From my perspective both of these changes could be merged back to master; perhaps the two of them cherry-picked as a single PR?

@sminnee sminnee merged commit 102f9d1 into silverstripe:master Oct 12, 2018
@kinglozzer kinglozzer deleted the null-template-lookups branch October 12, 2018 08:18
@kinglozzer kinglozzer mentioned this pull request Oct 17, 2018
Closed
@kinglozzer kinglozzer mentioned this pull request Jul 2, 2021
Closed
@GuySartorelli GuySartorelli mentioned this pull request Aug 26, 2022
Closed
5 tasks
@GuySartorelli GuySartorelli mentioned this pull request Sep 8, 2022
Merged
@GuySartorelli GuySartorelli mentioned this pull request Aug 8, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sminnee sminnee sminnee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinglozzer @sminnee