Refactor prepopulation #8395
Closed
Refactor prepopulation #8395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper is necessary when you want to replace a parameter with a non-literal such as a column name. This arises when you are transforming queries such as we do in the prepopulation query for Hierarchy::numChildren()
API: Hierarchy::stageChildren() customisations must be applied to the base class and not include record-specific behaviour. Adds the ability to prepopulate the cache for Hierarchy::numChildren() in a batch. Note that this optimisation means that stageChildren() is not called on each record in order to calculate numChildren(). This means that the structure of the stageChildren() query must be the same for all records and the behaviour cannot be customised only for a subclass of the base data class. For example, apply your customisations to SiteTree and not a subclass. This is an useful part of optimising the query count on tree generation. See #8379
This will avoid trying to count the children of childless object.
This provides a more extensible way of preopulating caches for optimised tree generation. Fixes #8391
sminnee
pushed a commit
to sminnee/silverstripe-cms
that referenced
this pull request
Sep 21, 2018
This was referenced Sep 21, 2018
Merged
sminnee
pushed a commit
to creative-commoners/silverstripe-fluent
that referenced
this pull request
Sep 23, 2018
ScopeyNZ
reviewed
Sep 23, 2018
| */ | ||
| public static function replace_parameter($sql, $paramIdx, $replacement, $skipEscaping = false) | ||
| { | ||
| $segments = preg_split('/\?/', $sql); |
There was a problem hiding this comment.
explode would be faster here.
There was a problem hiding this comment.
Addressed on parent PR by 07f9cdc
|
I've incorporated this into #8380 |
ScopeyNZ
pushed a commit
to creative-commoners/silverstripe-fluent
that referenced
this pull request
Sep 25, 2018
maxime-rainville
pushed a commit
to silverstripe/silverstripe-cms
that referenced
this pull request
Sep 25, 2018
* FIX: Use Hierarchy::prepopulate_numchildren_cache in tree-generation Only relevant if silverstripe/silverstripe-framework#8380 is avialable, however coded defensively so it can be merged before that PR if needs be. See silverstripe/silverstripe-framework#8379 * FIX: Use Hierarchy::prepopulateTreeDataCache() in CMS. Requires silverstripe/silverstripe-framework#8395 * Cache tree_class instead of assuming it will always be SiteTree.
maxime-rainville
pushed a commit
to silverstripe/silverstripe-versioned
that referenced
this pull request
Sep 25, 2018
* FIX: Use Hierarchy::prepopulateTreeDataCache() in CMS. Requires silverstripe/silverstripe-framework#8395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW: Add Hierarchy::prepopulateTreeDataCache()
This provides a more extensible way of preopulating caches for optimised
tree generation.
Fixes #8391