Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Add getJoinTable to MMTL #8065

Merged
merged 1 commit into from
May 31, 2018
Merged

NEW Add getJoinTable to MMTL #8065

merged 1 commit into from
May 31, 2018

Conversation

dhensby
Copy link
Contributor

@dhensby dhensby commented May 11, 2018

This is a small step to more closely aligning the API for ManyManyList and ManyManyThroughList

Ideally we'd add all the extra public methods that ManyManyList has to ManyManyThroughList

Missing methods:

  • getLocalKey
  • getForeignKey

This was referenced May 11, 2018
Closed
Closed
@tractorcow
Copy link
Contributor

It seems you are adding getjointable not getjoinclass.

@dhensby
Copy link
Contributor Author

dhensby commented May 13, 2018

It seems you are adding getjointable not getjoinclass

Whoops, that's right

@dhensby dhensby changed the title NEW Add getJoinClass to MMTL NEW Add getJoinTable to MMTL May 14, 2018
@dhensby dhensby force-pushed the pulls/4/mmtl-jointable branch from aac947c to 1a57c7c Compare May 14, 2018 10:21
@tractorcow
Copy link
Contributor

Regressions seem to be unrelated to the change.

@tractorcow tractorcow merged commit 2510935 into silverstripe:4 May 31, 2018
@dhensby dhensby deleted the pulls/4/mmtl-jointable branch June 4, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tractorcow tractorcow tractorcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhensby @tractorcow