Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to travis trusty dist (3.x) #7366

Closed
wants to merge 2 commits into from

Conversation

chillu
Copy link
Member

@chillu chillu commented Sep 12, 2017

See #7092 for context.

@dhensby
Copy link
Contributor

dhensby commented Sep 12, 2017

We can't use trusty for the 3.x branch because 5.3 is not supported

@dhensby dhensby closed this Sep 12, 2017
@chillu
Copy link
Member Author

chillu commented Sep 12, 2017

Oh yep - the 5.3 build fails: https://travis-ci.org/silverstripe/silverstripe-framework/builds/274452277

https://docs.travis-ci.com/user/reference/trusty/#PHP-images

Note: We do not support PHP versions 5.2.x and 5.3.x on Trusty. Specifying it will result in build failure. If you need to test with these versions, use Precise.

So given that Travis is (tentatively) ending precise support next April, but we want to support 3.x until late 2019, we have a bit of a problem. PHP 5.3 is already end of life though, so I'd say we just remove 5.3 builds now and make its support a "best effort" basis. If you're still running 5.3 now in production, you've got other problems than failing builds on framework. @silverstripe/core-team thoughts?

@kinglozzer
Copy link
Member

just remove 5.3 builds now and make its support a "best effort" basis. If you're still running 5.3 now in production, you've got other problems

Agreed 👍.

@sminnee
Copy link
Member

sminnee commented Sep 12, 2017

Seems okay but not a priority until February ;-)

@dhensby
Copy link
Contributor

dhensby commented Sep 12, 2017

Yeo - let's keep 5.3 builds for as long as we can and take them off when we have to.

I'm also not against dropping 5.3 support in a minor release, so we can always discuss that when the time comes ;)

@sminnee
Copy link
Member

sminnee commented Sep 12, 2017

This would be a great time to have live usage stats being beamed to us, e.g. via a module that phoned home to check for module updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants