FIX illegal_extensions in unit tests not being honored #6760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenz
changed the title
mikenz
commented
Mar 30, 2017
| @@ -356,15 +356,15 @@ public static function setUpBeforeClass() | |||
| continue; | |||
| } | |||
| foreach ($extensions as $extension) { | |||
| if (!class_exists($extension) ||$class::has_extension($extension)) { | |||
| if (!class_exists($extension) || !$class::has_extension($extension)) { | |||
There was a problem hiding this comment.
This is the important change. The rest is just whitespace.
|
I think the test failure may well be related? |
|
The Travis failure is just this: https://github.com/silverstripe/silverstripe-versioned/pull/6/files |
|
@mikenz ah - I've merged that and restarted the tests |
|
Looks like the CMS test isn't getting on to well :/ |
|
Oh, I've fixed those locally - I'll create a PR for them too |
|
Fix CMS unit tests silverstripe/silverstripe-cms#1771 |
|
Right, I seemed to have missed the PR for cms when I did the work last night- I've opened that here: silverstripe/silverstripe-cms#1772 and it looks like the tests will pass. This PR looks good |
dhensby
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.