FIX Add quotes to constants in YAML to ensure syntax validity #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tractorcow
suggested changes
Feb 27, 2017
src/Core/Injector/Injector.php
Outdated
| // Evaluate constants surrounded by back ticks | ||
| if (preg_match('/^`(?<name>[^`]+)`$/', $value, $matches)) { | ||
| // Evaluate constants surrounded by back ticks (and quotes) | ||
| if (preg_match('/^[\'"]?`(?<name>[^`]+)`[\'"]?$/', $value, $matches)) { |
There was a problem hiding this comment.
If you quote the yml string it will come out unquoted when parsed by the yml parser. You shouldn't be looking for an extra layer of quotes here.
robbieaverill
force-pushed
the
bugfix/quote-constants-in-yaml
branch
from
458ea65 to
badf7d3
Compare
tractorcow
approved these changes
Feb 27, 2017
|
Can merge on green. |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6574
I didn't add a PHPUnit 5.7 build just yet.