-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Replace deprecated %s placeholders in translations with named placeholders #6598
FIX Replace deprecated %s placeholders in translations with named placeholders #6598
Conversation
6aa85ae
to
debd432
Compare
@tractorcow I'll rebase this branch shortly. Regarding the deprecation/removal of that method we talked about (#vague) - the changelog currently says that the |
56064e3
to
30c7ca5
Compare
|
30c7ca5
to
a1b6623
Compare
The plan is to fork translations at some point in the future, and then merge this PR into that, before pushing up to transifex. That will allow us to replace upstream strings without affecting 3.x releases. |
what's the progress on this? @robbieaverill it'll need a rebase at some point |
@dhensby yeah I'll rebase it when we're ready to look at it, otherwise it'll just keep needing to be rebased as the translations change :D |
a1b6623
to
0a86177
Compare
…ceholders * Remove the use of sprintf and %s placeholders in the i18n tests
0a86177
to
1867ee8
Compare
This pull request largely removed the use of
sprintf(_t(TRANSNAME, '... %s'), $myVar)
in favour of the named placeholder equivalent_t(TRANSNAME, '... {myvar}', ['myvar' => $myVar])
.All translations have been updated to ensure they don't break before in the short term.
There are some areas especially in the tests that use this deliberately to test against, so I've left them alone for now, but perhaps we should remove the syntax from the tests and not test the behaviour any more?
Resolves #6582