Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Do not mark changed when setting value in constructor #11478

Merged
merged 1 commit into from
Nov 26, 2024
Merged

FIX Do not mark changed when setting value in constructor #11478

merged 1 commit into from
Nov 26, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 26, 2024 •
edited
Loading

Issue silverstripe/.github#341

Fixes https://github.com/symbiote/silverstripe-multivaluefield/actions/runs/11943348948/job/33292246916

1) Symbiote\MultiValueField\Tests\MultiValueFieldTest::testIsChanged
Failed asserting that true is false.

/home/runner/work/silverstripe-multivaluefield/silverstripe-multivaluefield/tests/MultiValueFieldTest.php:75

Also fixes linting issue

@emteknetnz emteknetnz mentioned this pull request Nov 26, 2024
Closed
@emteknetnz emteknetnz marked this pull request as ready for review November 26, 2024 04:53
@emteknetnz emteknetnz force-pushed the pulls/6/broken-builds branch from d98b711 to cdda1b8 Compare November 26, 2024 05:05
emteknetnz
emteknetnz commented Nov 26, 2024
View reviewed changes
src/ORM/DataObject.php
@@ -964,7 +964,7 @@ public function classDescription(): ?string
public function i18n_classDescription(): ?string
{
$notDefined = 'NOT_DEFINED';
$description = _t(static::class.'.CLASS_DESCRIPTION', $this->classDescription() ?? $notDefined);
$description = _t(static::class . '.CLASS_DESCRIPTION', $this->classDescription() ?? $notDefined);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you mean "this fixes the linting issue"
I spent a good five minutes trying to figure out what the linting issue was with this, why CI was green, and why you were pointing it out rather than fixing it. Full sentences save time :p

GuySartorelli
GuySartorelli approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit c651007 into silverstripe:6 Nov 26, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/broken-builds branch November 26, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli