DEP Set minimum version of symfony/cache to 7.1.5 #11466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/6/broken-builds
branch
from
387b4b7 to
859f4f7
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/6/broken-builds
branch
from
859f4f7 to
24e2a91
Compare
emteknetnz
changed the title
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/6/broken-builds
branch
2 times, most recently
from
ab82621 to
3d868ce
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/6/broken-builds
branch
from
3d868ce to
a08a119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#328
Two commits, so don't squash merge
1
Require https://github.com/symfony/cache/releases/tag/v7.1.5 which has a fix to work with newer versions of redis
Fixes --prefer-lowest build https://github.com/silverstripe/silverstripe-framework/actions/runs/11826436315/job/32952439907
PHP Fatal error: Declaration of Symfony\Component\Cache\Traits\Redis6Proxy::hSet($key, $member, $value): Redis|int|false must be compatible with Redis::hSet(string $key, mixed ...$fields_and_vals): Redis|int|false in /home/runner/work/silverstripe-framework/silverstripe-framework/vendor/symfony/cache/Traits/Redis6Proxy.php on line 5192
Fix DataProviders in unit test after merge-up from 5