Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Combine Sortable, Filterable and Limitable into SS_List #11433

Merged
merged 1 commit into from
Oct 30, 2024
Merged

API Combine Sortable, Filterable and Limitable into SS_List #11433

merged 1 commit into from
Oct 30, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Oct 21, 2024 •
edited
Loading

Issue #8778

  1. Remove interfaces
  • Sortable
  • Filterable
  • Limitable
  1. Adds methods to SS_List
  • columnUnique()
  • count()
  • excludeAny()
  • exists()
  • getIterator()
  • offsetExists()
  • offsetGet()
  • offsetSet()
  • offsetUnset()
  1. Update ListDecorator
  • Add excludeAny()
  • Rename Count() to count()
  1. Adds strong typing to all SS_List methods and implementing subclass methods

@emteknetnz emteknetnz mentioned this pull request Oct 21, 2024
Closed
5 tasks
@emteknetnz emteknetnz force-pushed the pulls/6/ss-list-combine branch 2 times, most recently from 5a6fa6f to 3ce511c Compare October 21, 2024 04:53
@emteknetnz emteknetnz marked this pull request as draft October 21, 2024 05:59
@emteknetnz emteknetnz force-pushed the pulls/6/ss-list-combine branch 12 times, most recently from e6fee3c to 423d79a Compare October 24, 2024 02:56
@emteknetnz emteknetnz marked this pull request as ready for review October 24, 2024 05:49
GuySartorelli
GuySartorelli requested changes Oct 24, 2024
View reviewed changes
src/Model/List/ArrayList.php Show resolved Hide resolved
src/Model/List/ArrayList.php Outdated Show resolved Hide resolved
src/Model/List/ListDecorator.php Show resolved Hide resolved
src/Model/List/ListDecorator.php Outdated Show resolved Hide resolved
src/Model/List/ListDecorator.php Outdated Show resolved Hide resolved
src/ORM/EagerLoadedList.php Show resolved Hide resolved
src/ORM/DataList.php Outdated Show resolved Hide resolved
src/ORM/EagerLoadedList.php Outdated Show resolved Hide resolved
src/ORM/ManyManyList.php Outdated Show resolved Hide resolved
src/ORM/Search/BasicSearchContext.php Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6/ss-list-combine branch 8 times, most recently from 08353c5 to 47cca2b Compare October 29, 2024 01:28
@emteknetnz emteknetnz force-pushed the pulls/6/ss-list-combine branch from 47cca2b to 0022287 Compare October 29, 2024 22:09
@emteknetnz emteknetnz force-pushed the pulls/6/ss-list-combine branch from 0022287 to f5730a3 Compare October 29, 2024 23:05
@GuySartorelli GuySartorelli merged commit 57ae271 into silverstripe:6 Oct 30, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/ss-list-combine branch October 30, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli