Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Rename Deprecation::withNoReplacement #11390

Merged
merged 1 commit into from
Sep 18, 2024
Merged

API Rename Deprecation::withNoReplacement #11390

merged 1 commit into from
Sep 18, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Sep 17, 2024
Closed
4 tasks
@GuySartorelli GuySartorelli force-pushed the pulls/5/suppress-deprecation branch from 5c52b5b to f4d5b7b Compare September 17, 2024 22:49
This was referenced Sep 17, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
emteknetnz
emteknetnz requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

withSuppressedWarning() should be withSurpressedNotice() as we're surpressing Deprecation::notice()

This applies to all PRs linked in the issue

@GuySartorelli
Copy link
Member Author

Arguably the notice method is poorly named but to avoid ping pong and unnecessary additional effort I'll update the new method name.

@GuySartorelli GuySartorelli force-pushed the pulls/5/suppress-deprecation branch from f4d5b7b to 87beabe Compare September 18, 2024 21:24
@GuySartorelli GuySartorelli changed the title API Rename Deprecation::withNoReplacement to Deprecation::withSuppressedWarning API Rename Deprecation::withNoReplacement Sep 18, 2024
@GuySartorelli GuySartorelli mentioned this pull request Sep 18, 2024
Merged
GuySartorelli
GuySartorelli commented Sep 18, 2024
View reviewed changes
src/Dev/Deprecation.php Outdated
private static bool $insideWithNoReplacement = false;
private static bool $insideWarningSuppression = false;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't mention it but I assume you want these renamed too, so I'll do that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@GuySartorelli GuySartorelli force-pushed the pulls/5/suppress-deprecation branch from 87beabe to 96284f3 Compare September 18, 2024 21:33
@GuySartorelli GuySartorelli mentioned this pull request Sep 18, 2024
Merged
@emteknetnz emteknetnz merged commit 6287b6e into silverstripe:5 Sep 18, 2024
14 checks passed
@emteknetnz emteknetnz deleted the pulls/5/suppress-deprecation branch September 18, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz