Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Auto-scaffold Member and Group with appropriate form fields #11285

Merged

Conversation

GuySartorelli
Copy link
Member

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran all the PRs against recipe-kitchen-sink CMS 6 in CI - seems like a lot of failures, https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/9605560072/job/26501273469 - I also did a subsequent kitchen-sink CMS 6 in CI without any PRs and it went green - https://github.com/emteknetnz/recipe-kitchen-sink/actions/runs/9591494828

There are more failures then I would expect, so possibly I've done something wrong though it's no immediately obivous to be - could you have a check on some of the failures and see if you can work out what's going on?

@GuySartorelli
Copy link
Member Author

Fixed the one issue that seemed legitimate, now running a new sink run. Link in issue.

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works well

@emteknetnz emteknetnz merged commit a684c8c into silverstripe:6 Jun 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants