Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Support pre tag #11253

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented May 20, 2024

Description

POC: Another solution to support using "code" string in WYSIWYG. User can add code snippet wrapped in <pre> HTML tag. However, there is some difference in how the snippet code will be processed depending on how it was entered. If the snippet code was entered through Source Code, then all its contents will be processed and, for example, HTML tags will not be displayed in the text area. If the code is entered directly into the HTMLEDitor text field, then all internal tags will be displayed as text.

Test steps

  • Insert <pre class="any"><div><strong>My test</strong>code snippet</div></pre> into HTMLEditorField;
  • Save;
  • You should see <div><strong>My test</strong>code snippet</div> in HTMLEditorField;
  • You should see <div><strong>My test</strong>code snippet</div> on Page;

Parent issue

@sabina-talipova sabina-talipova force-pushed the pulls/5.2/fix-htmlentities-issue-2 branch from ee0a185 to 4fdbe39 Compare May 20, 2024 00:37
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already #11243 linked on this issue that fixes the linked issue?

Seems like we don't need this PR?

@sabina-talipova sabina-talipova deleted the pulls/5.2/fix-htmlentities-issue-2 branch May 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants