-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Rendering scalars in ArrayList in templates #11238
Merged
GuySartorelli
merged 1 commit into
silverstripe:5
from
creative-commoners:pulls/5/viewable-scalar
May 15, 2024
Merged
ENH Rendering scalars in ArrayList in templates #11238
GuySartorelli
merged 1 commit into
silverstripe:5
from
creative-commoners:pulls/5/viewable-scalar
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/viewable-scalar
branch
2 times, most recently
from
May 14, 2024 05:33
458bd44
to
c93d391
Compare
GuySartorelli
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a note about this to the CMS 5.3 changelog
Have created changlog entry |
emteknetnz
force-pushed
the
pulls/5/viewable-scalar
branch
from
May 14, 2024 23:59
c93d391
to
cb7a480
Compare
emteknetnz
force-pushed
the
pulls/5/viewable-scalar
branch
from
May 15, 2024 03:06
cb7a480
to
ebd28d8
Compare
GuySartorelli
requested changes
May 15, 2024
emteknetnz
force-pushed
the
pulls/5/viewable-scalar
branch
from
May 15, 2024 04:31
ebd28d8
to
12a741f
Compare
if (is_scalar($on) || is_null($on)) {
$on = $this->convertPrimitiveToDBField($on);
}
It was updated |
GuySartorelli
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11196