Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Rendering scalars in ArrayList in templates #11238

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented May 14, 2024

Issue #11196

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a note about this to the CMS 5.3 changelog

src/View/SSViewer_Scope.php Outdated Show resolved Hide resolved
src/View/SSViewer_Scope.php Outdated Show resolved Hide resolved
src/View/SSViewer_Scope.php Outdated Show resolved Hide resolved
tests/php/View/SSViewerTest.php Outdated Show resolved Hide resolved
@emteknetnz
Copy link
Member Author

Have created changlog entry

@emteknetnz emteknetnz force-pushed the pulls/5/viewable-scalar branch from c93d391 to cb7a480 Compare May 14, 2024 23:59
src/View/SSViewer_Scope.php Outdated Show resolved Hide resolved
src/View/SSViewer_Scope.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/viewable-scalar branch from cb7a480 to ebd28d8 Compare May 15, 2024 03:06
src/View/SSViewer_Scope.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/viewable-scalar branch from ebd28d8 to 12a741f Compare May 15, 2024 04:31
@emteknetnz
Copy link
Member Author

if (is_scalar($on) || is_null($on)) {
            $on = $this->convertPrimitiveToDBField($on);
        }

Still not done?

It was updated

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 8afe1ad into silverstripe:5 May 15, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/viewable-scalar branch May 15, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants