FIX 'which' check in 'sake' now works for aliases #11232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoLdman
changed the title
GuySartorelli
requested changes
May 15, 2024
There was a problem hiding this comment.
Docs for the command command for future reference.
@michalkleiner and @minimalic can you please confirm if this works for you? I note there was discussion about the alternative PR, but hopefully this PR works for all those cases.
8 tasks
GuySartorelli
requested changes
May 17, 2024
Improves on the current implementations since 'command' already only returns executable commands. Additionally, the success output of 'command' is not standardized and may contain additional information. Therefore, a 'test' if the result of 'command' is a valid executable file, may fail incorrectly. Now just relying on the standardized exit status of 'command -v'.
The previous implementation used '&&' piping wich is handled differently in PHP and Bash code and therefore, may be confusing to a PHP developer. I refactored the function to use a traditional if statement.
Converted to 'if' to square bracket based testing to be in comply with the other 'if' statements in the script. Co-authored-by: Guy Sartorelli <[email protected]>
GuySartorelli
force-pushed
the
better-which-check-for-sake
branch
from
14f2608 to
01efd26
Compare
GuySartorelli
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sakemay wrongly exit early on itswhichcheck, since the current implementation does the following:command -vinformation about thewhichexecutableThis solution is problematic since the returned information string may include alias information (and more),
which
test -xcan not interpret.Additionally is the
test -xcheck unnecessary sincecommand -valready only returns executable command or fails if the command can not be found.Therefore, I changed the source to just check for the exit status of
command -v.Manual testing steps
Run
vendor/bin/sake dev/buildon a POSIX compliant system, wherewhichitself has been aliased.Issues
Pull request checklist