-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Update AttributesHTML to output alt attribute even if it's empty #11217
ENH Update AttributesHTML to output alt attribute even if it's empty #11217
Conversation
3a703eb
to
d42fa9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original AttributesHTML was only covered by indirect tests of classes using the trait. I decided to add an explicit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHPlinting failure
47a7008
to
9acbd60
Compare
Fixed the linting issue |
AttributeHTML
want to suppress attributes with falsy values.When rendering Images and the
alt
attribute contains a blank string, the attribute should be rendered anyway.Arguably this should be on
ImageManipulation
instead, but it seems like an sensible exception to have across the board. I haven't decided yet.Issue