Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix test for required password fields in kitchen sink #11111

Merged

Conversation

GuySartorelli
Copy link
Member

Description

Fixes https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/7572648719/job/20622988035

This is caused by the text field template being overridden for the front-end in a CWP module. The way the template is overridden, there's not much we can do to fix the actual functionality in that scenario without adding some hard coupling between PasswordField and ConfirmedPasswordField classes - which isn't really patch release friendly.

This PR changes the test to validate just that it works in the CMS with default templates - it makes no promises about the functionality working on the front-end.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • CI is green

@emteknetnz emteknetnz merged commit b979ce5 into silverstripe:4.13 Jan 19, 2024
15 checks passed
@emteknetnz emteknetnz deleted the pulls/4.13/broken-builds branch January 19, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants