Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two related bugs.
For both bugs, this PR logs the error, but lets code execution continue
Note that there are two ways this exception can occur:
admin_url
is not a valid email address, soRfcComplianceException
is thrownTransportExceptionInterface
is thrownBug one
If there's an exception thrown when trying to send an email to a user in live mode when their password has been changed, the new password does not get saved.
Bug two
No issue open
When using the password recovery functionality ("I've lost my password"), if an exception is thrown when trying to send the recovery email, the whole page just breaks.
Instead of that, the user should be given a user-friendly error message, and the cause of the error should be logged.
Notes