Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused lines in findTab() #11091

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Remove unused lines in findTab() #11091

merged 2 commits into from
Dec 14, 2023

Conversation

edwilde
Copy link
Contributor

@edwilde edwilde commented Dec 12, 2023 •
edited
Loading

Fixes #11090

These lines don't appear to be of any use...likely copied over from findOrMakeTab() below.

@edwilde edwilde changed the title Remove unused line in findTab() Remove unused lines in findTab() Dec 12, 2023
GuySartorelli
GuySartorelli approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Helps keep things tidy.

@GuySartorelli GuySartorelli merged commit 3acd6d3 into silverstripe:5 Dec 14, 2023
15 checks passed
@edwilde edwilde deleted the patch-16 branch December 15, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused code in FieldList::findTab()
3 participants
@edwilde @michalkleiner @GuySartorelli