FIX: UnsavedRelationList first/last to return null if list is empty (fixes #11083) #11085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinglozzer
commented
Dec 4, 2023
| if (is_numeric($item)) { | ||
| $item = DataObject::get_by_id($this->dataClass, $item); | ||
| } | ||
| if (!empty($this->extraFields[key($this->items)])) { | ||
| if ($item && !empty($this->extraFields[key($this->items)])) { |
There was a problem hiding this comment.
Not actually part of this fix but seemed like sensible defensive coding. Happy to remove or break out into a separate commit if preferred
kinglozzer
commented
Dec 4, 2023
| if (!empty($this->extraFields[key($this->items)])) { | ||
| $item = end($this->items) ?: null; | ||
| if (is_numeric($item)) { | ||
| $item = DataObject::get_by_id($this->dataClass, $item); |
There was a problem hiding this comment.
Pushed a second commit for this bugfix. tldr; UnsavedRelationList items array can contain both full objects (for unsaved records) or just IDs (for already existing records). This code already exists in first(), I think last() was just overlooked.
Covered by the test already added for the main fix (that’s how I noticed this!): https://github.com/silverstripe/silverstripe-framework/actions/runs/7085966036/job/19283271493?pr=11085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11083