Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use SearchableDropdownField for autoscaffolded has_one relationships #11071

Merged
merged 1 commit into from
Dec 18, 2023
Merged

ENH Use SearchableDropdownField for autoscaffolded has_one relationships #11071

merged 1 commit into from
Dec 18, 2023

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 27, 2023 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request Nov 27, 2023
Closed
8 tasks
@emteknetnz emteknetnz force-pushed the pulls/5/foreign-key-field-scaffold branch 4 times, most recently from 0d8289a to d0d7d14 Compare November 29, 2023 01:08
GuySartorelli
GuySartorelli requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, make the requested changes, and add a note about this to the changelog (sorry, should have thought about that before merging the docs PR)

Also please double check if dropdown_field_threshold is documented and if so, update that doc.

@emteknetnz emteknetnz force-pushed the pulls/5/foreign-key-field-scaffold branch from d0d7d14 to c0b13f2 Compare December 17, 2023 21:17
@emteknetnz emteknetnz marked this pull request as ready for review December 17, 2023 21:21
@emteknetnz emteknetnz force-pushed the pulls/5/foreign-key-field-scaffold branch from c0b13f2 to f167972 Compare December 17, 2023 21:21
@emteknetnz
Copy link
Member Author

emteknetnz commented Dec 17, 2023 •
edited
Loading

dropdown_field_threshold isn't documented

Have added docs PR - silverstripe/developer-docs#425

@emteknetnz emteknetnz force-pushed the pulls/5/foreign-key-field-scaffold branch from f167972 to 8b38973 Compare December 17, 2023 21:35
GuySartorelli
GuySartorelli requested changes Dec 17, 2023
View reviewed changes
src/Forms/SearchableDropdownField.php Outdated Show resolved Hide resolved
src/ORM/FieldType/DBForeignKey.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/foreign-key-field-scaffold branch from 8b38973 to e66c1ae Compare December 18, 2023 21:04
GuySartorelli
GuySartorelli approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit e7775a6 into silverstripe:5 Dec 18, 2023
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/foreign-key-field-scaffold branch December 18, 2023 21:42
@GuySartorelli GuySartorelli mentioned this pull request Mar 11, 2024
Open
2 tasks
This was referenced May 12, 2024
Closed
Closed
@maxime-rainville maxime-rainville mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli