Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use field editorconfig when sanitising content #10977

Conversation

blueo
Copy link
Contributor

@blueo blueo commented Oct 15, 2023

see #10975 for the original issue
This changes to using the field configured HTMLEditorConfig instance when sanitising content for saving. It will fall back to the active config if none is defined on the field.

Issue

@blueo
Copy link
Contributor Author

blueo commented Oct 15, 2023

Wasn't exactly sure which branch to target - currently 5 but maybe should b 4?

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 24, 2023

If this is a bug that affects CMS 4, please target the 4.13 branch.
For future reference: https://docs.silverstripe.org/en/contributing/code/#picking-the-right-version

@blueo blueo force-pushed the pulls/use-field-editorconfig-when-sanitizing branch from 3552eec to e5eb98c Compare October 24, 2023 23:09
@blueo blueo changed the base branch from 5 to 4.13 October 24, 2023 23:09
@blueo
Copy link
Contributor Author

blueo commented Oct 24, 2023

thanks I'll keep that for reference as I often wonder which one :)

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great locally, thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants