Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Multi HTML entities in short codes #10903

Merged
merged 1 commit into from
Aug 8, 2023
Merged

FIX Multi HTML entities in short codes #10903

merged 1 commit into from
Aug 8, 2023

Conversation

sabina-talipova
Copy link
Contributor

Description

  • Turn off double_encode for special characters in TextareaField.

Parent issue

@sabina-talipova sabina-talipova mentioned this pull request Aug 7, 2023
Closed
@sabina-talipova sabina-talipova force-pushed the pulls/4.13/fix-multi-html-entities-in-shortcode branch from b9251f6 to 6f25498 Compare August 7, 2023 04:32
GuySartorelli
GuySartorelli requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned below, this breaks TextareaField.

Instead, implement this in HTMLEditorField. You'll also need to check whether this is needed for HTMLReadonlyField.

src/Forms/TextareaField.php Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli requested changes Aug 7, 2023
View reviewed changes
src/Forms/TextareaField.php Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/4.13/fix-multi-html-entities-in-shortcode branch 5 times, most recently from af81140 to 37d2ebb Compare August 8, 2023 00:26
@sabina-talipova sabina-talipova force-pushed the pulls/4.13/fix-multi-html-entities-in-shortcode branch from 37d2ebb to 037168a Compare August 8, 2023 01:08
GuySartorelli
GuySartorelli approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well locally.

@GuySartorelli GuySartorelli merged commit 4f6ab33 into silverstripe:4.13 Aug 8, 2023
@GuySartorelli GuySartorelli deleted the pulls/4.13/fix-multi-html-entities-in-shortcode branch August 8, 2023 01:20
@maxime-rainville maxime-rainville mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli