FIX Don't assume searchableFields() exists in gridfield filter #10772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed unit test is unrelated |
GuySartorelli
force-pushed
the
pulls/4.13/gridfieldfilter-regression
branch
from
15727b3 to
01808a8
Compare
michalkleiner
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some projects and modules which implement some
ViewableDataclass which has asummaryFields()method to bypass assumptions this component already does (e.g. https://github.com/silverstripe/silverstripe-search-service/blob/2/src/Admin/IndexedDocumentsResult.php). In 4.13.0 we suddenly assumed that thesearchableFields()method was also present, which is a breaking change. This resolves back to using the legacy filter code if the expected methods don't exist (see #10733)Issue