FIX Remove legacy filter icon #10736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/pulls/5.0/double-sort/pulls/5.0/double-filter
branch
from
23d72c0 to
84273b8
Compare
GuySartorelli
deleted the
pulls/pulls/5.0/double-sort/pulls/5.0/double-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1478
Deleting the old code block because it's purely for the previously and now deprecated
$filter->useLegacyFilterHeaderhttps://github.com/silverstripe/silverstripe-framework/blob/4/src/Forms/GridField/GridFieldSortableHeader.php#L194
The "normal" filter icon (the one we want to retain) is set in GridFieldFilterHeader for both
4and5- https://github.com/silverstripe/silverstripe-framework/blob/4.13/src/Forms/GridField/GridFieldFilterHeader.php#L542