Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove old deprecation warnings #10716

Merged
merged 1 commit into from
Mar 2, 2023
Merged

MNT Remove old deprecation warnings #10716

merged 1 commit into from
Mar 2, 2023

Conversation

emteknetnz
Copy link
Member

GuySartorelli
GuySartorelli requested changes Mar 2, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also f6d8d27#r102697124 and f6d8d27#r102697164

@emteknetnz
Copy link
Member Author

There's multiple instances of @deprecation and Deprecation in the 5.0 codebase - we'll create a new card to deal with the all

GuySartorelli
GuySartorelli approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out there are a lot of deprecation annotations in 5.... Steve is making a separate card to handle those.

@GuySartorelli GuySartorelli merged commit bdf90fb into silverstripe:5.0 Mar 2, 2023
@GuySartorelli GuySartorelli deleted the pulls/5.0/remove-deprecation branch March 2, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli