MNT Tweak some test to account for slightly different sorting logic in PostgreSQL #10693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $list = $list->sort($emtpyValue); | ||
| $this->assertSame(['Subteam 1'], $list->limit(1)->column('Title')); | ||
| } | ||
|
|
||
| public function provideSortScalarValues(): array | ||
| { | ||
| return [ | ||
| [null, 'wipes-existing'], |
There was a problem hiding this comment.
This scenario was testing that calling sort with null unsets the order by clause. I've replaced it with a sightly different test below.
| @@ -1831,7 +1831,7 @@ public function testMapInCMSGroups(array $groupFixtures, array $groupCodes, arra | |||
| $result = Member::mapInCMSGroups($groups); | |||
| $this->assertInstanceOf(Map::class, $result); | |||
|
|
|||
| $this->assertSame($expectedUsers, $result->keys()); | |||
| $this->assertEqualsCanonicalizing($expectedUsers, $result->keys()); | |||
There was a problem hiding this comment.
In PostgreSQL, the result was returning the keys in a slightly different order.
The order of the results is irrelevant here. `assertEqualsCanonicalizing' sorts the arrays before comparing them.
kinglozzer
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries without a ORDER BY clause in PostgreSQL are return in a slightly different order. This leads to somewhat different results in some context.
Parent issue
silverstripe/silverstripe-postgresql#143