-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Add new deprecation notices. #10691
Merged
emteknetnz
merged 1 commit into
silverstripe:4
from
creative-commoners:pulls/4/deprecations
Feb 15, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -254,11 +254,11 @@ protected function processChunk($filepath, $preview = false) | |
Deprecation::notice('4.12.0', 'Process rows individually instead'); | ||
$results = BulkLoader_Result::create(); | ||
|
||
$csv = new CSVParser( | ||
$filepath, | ||
$this->delimiter, | ||
$this->enclosure | ||
); | ||
$delimiter = $this->delimiter; | ||
$enclosure = $this->enclosure; | ||
$csv = Deprecation::withNoReplacement(function () use ($filepath, $delimiter, $enclosure) { | ||
return new CSVParser($filepath, $delimiter, $enclosure); | ||
}); | ||
Comment on lines
-257
to
+261
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the only usage of this class in our code that I could find. Since this whole method is deprecated, it's easier to just wrap this instantiation than to replace it with the |
||
|
||
// ColumnMap has two uses, depending on whether hasHeaderRow is set | ||
if ($this->columnMap) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm explicitly not wrapping this one in
Deprecation::withNoReplacement()
because there are only a few instances of it in use in our code, and we can wrap those instead. This seems likely to be used pretty frequently in projects so it's good for their uses to pop up in the main deprecation notices.