FIX Prevent backslash in CSS class name #10663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
changed the title
|
I reckon we can treat this as a bugfix and target |
|
@michalkleiner :) the sooner the better |
|
:) i know i can use hidden_permissions |
|
Yup I agree. If you retarget this to 4.12 we can release as a bug fix. If I see this is still targeting 4 when I get to work in Monday I'll probably just merge as is and you'll have to wait for 4.13 |
|
Or create a new PR with the same code targeting 4.12. Can you rebase and retarget @lekoala? |
lekoala
added a commit
to lekoala/silverstripe-framework
that referenced
this pull request
Jan 30, 2023
|
@michalkleiner here is the other pr #10667 |
since the default code is using get_called_class, you can end up with \ in the class name which is an escape character for css selectors this update convert for example even valCMS_ACCESS_SilverStripe\VersionedAdmin\ArchiveAdmin to even valCMS_ACCESS_SilverStripe-VersionedAdmin-ArchiveAdmin ArchiveAdmin class should probably implement private static $required_permission_codes = 'CMS_ACCESS_ArchiveAdmin '; also
|
Rebased for you |
michalkleiner
approved these changes
Jan 30, 2023
|
Released in 4.12.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the default code is using get_called_class, you can end up with \ in the class name which is an escape character for css selectors this update convert for example
even valCMS_ACCESS_SilverStripe\VersionedAdmin\ArchiveAdmin to
even valCMS_ACCESS_SilverStripe-VersionedAdmin-ArchiveAdmin
ArchiveAdmin class should probably implement private static $required_permission_codes = 'CMS_ACCESS_ArchiveAdmin '; also