DEP Replace thirdparty simpletest with symfony domcrawler #10643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should run this through a full kitchen sink test suite before considering it safe |
3 tasks
sabina-talipova
force-pushed
the
pulls/5/replace-simpletest
branch
3 times, most recently
from
c35e739 to
2d83487
Compare
sabina-talipova
force-pushed
the
pulls/5/replace-simpletest
branch
from
2d83487 to
3815e1a
Compare
GuySartorelli
commented
Feb 2, 2023
GuySartorelli
commented
Feb 2, 2023
sabina-talipova
force-pushed
the
pulls/5/replace-simpletest
branch
from
3815e1a to
d23191b
Compare
GuySartorelli
commented
Feb 6, 2023
sabina-talipova
force-pushed
the
pulls/5/replace-simpletest
branch
2 times, most recently
from
2062ea5 to
5d9190f
Compare
GuySartorelli
commented
Feb 7, 2023
sabina-talipova
force-pushed
the
pulls/5/replace-simpletest
branch
4 times, most recently
from
c85f588 to
d8aa323
Compare
GuySartorelli
commented
Feb 7, 2023
sabina-talipova
force-pushed
the
pulls/5/replace-simpletest
branch
from
0c72686 to
2e08a90
Compare
Co-authored-by: Guy Sartorelli <[email protected]>
sabina-talipova
force-pushed
the
pulls/5/replace-simpletest
branch
from
2e08a90 to
9d13f35
Compare
|
I can't click "approve" because I created the PR originally but I approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for replacing the
simpletestwith symfony/domcrawlerParent issue