FIX Allow passing objects to InjectionCreator::create() #10555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4.11/inject-objects
branch
from
063674c to
bb44dfe
Compare
Co-authored-by: Nate Devereux <[email protected]>
emteknetnz
force-pushed
the
pulls/4.11/inject-objects
branch
from
bb44dfe to
e3a6cad
Compare
michalkleiner
approved these changes
Oct 19, 2022
|
Looks good to me! |
|
@n8-dev I've tagged 4.11.11 for you https://github.com/silverstripe/silverstripe-framework/releases/tag/4.11.11 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10533
Replacement for #10539
Main difference is the use of
get_class($class)instead ofreturn $classto ensure that a new instance is always created. I've also changed the unit testing.I've also tidied up some of the previous
?? ''added as part of the php 8.1 code-writingThis is technically a bugfix since it restores previous behavior of allow anonymous classes, which will unintentional, seems like it has a valid use case in unit testing. Anonymous classes can be cleaner to use then the at times cumbersome combination of
TestOnlyclasses withprivate static $extra_dataobjectsI've put n8-dev down as a co-author