Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Strongly-type action method signatures #10536

Merged
merged 1 commit into from
Oct 18, 2022
Merged

API Strongly-type action method signatures #10536

merged 1 commit into from
Oct 18, 2022

Conversation

emteknetnz
Copy link
Member

Issue #10466

@emteknetnz emteknetnz mentioned this pull request Oct 10, 2022
Closed
3 tasks
@emteknetnz emteknetnz marked this pull request as draft October 10, 2022 03:10
@emteknetnz emteknetnz force-pushed the pulls/5/action-signature branch 8 times, most recently from 82eee17 to a3e276a Compare October 11, 2022 06:18
@emteknetnz emteknetnz changed the title [WIP] API Strongly-type action method signatures API Strongly-type action method signatures Oct 11, 2022
@emteknetnz emteknetnz marked this pull request as ready for review October 11, 2022 07:21
GuySartorelli
GuySartorelli requested changes Oct 13, 2022
View reviewed changes
src/Control/Controller.php Outdated Show resolved Hide resolved
src/Control/Controller.php Show resolved Hide resolved
src/Dev/DevBuildController.php Show resolved Hide resolved
src/Forms/FormRequestHandler.php Show resolved Hide resolved
dhensby
dhensby reviewed Oct 14, 2022
View reviewed changes
src/Control/Controller.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/action-signature branch 2 times, most recently from 71b6f0c to b169359 Compare October 17, 2022 04:10
@emteknetnz emteknetnz force-pushed the pulls/5/action-signature branch from b169359 to a57c731 Compare October 17, 2022 04:58
GuySartorelli
GuySartorelli approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be merged until the related PRs are ready to avoid breaking CI

@GuySartorelli GuySartorelli merged commit 868f790 into silverstripe:5 Oct 18, 2022
@GuySartorelli GuySartorelli deleted the pulls/5/action-signature branch October 18, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhensby dhensby dhensby left review comments

@michalkleiner michalkleiner michalkleiner left review comments

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emteknetnz @michalkleiner @dhensby @GuySartorelli