API Rescue Master Branch PR: Update MigrationTask class to be an abstract class #10458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
GuySartorelli
force-pushed
the
pulls/5/rescue-master-abstract-migrationtask
branch
from
1cb0658 to
e42ed95
Compare
GuySartorelli
changed the title
emteknetnz
requested changes
Aug 24, 2022
There was a problem hiding this comment.
Similar to #10461 - I don't like having an abstract class without any abstract methods. It goes against how people normally thing about abstract classes.
Seems like instead we could do something else like just filter out MigrationTask::class from whatever piece of code finds all the available Tasks that can be run
|
|
|
OK fair enough, I was thinking about it wrong |
emteknetnz
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescues #9432
Parent issue