FIX Check if blank method passed #10417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-cms#2750
Checking for emtpy($method) protects against null being passed in for $method and later on triggering a deprecation warning in PHP 8.1 on strtolower($method);
Note: docblock params and return types are wrong because null is being passed in at least one instance (so not limited to string) and this function already returns null, so array return type is also incorrect. There's a much wider issue with the docblock params and return type accuracy so not going to fix here.