Update boot strap to use our own .env file parsing

In light of an issue with putenv behaving asyncronously
it results in a race condition (particularly on windows
machines it would seem) with apache in the least. So
we will use our own parsing and set to a cache instead

composer.json

@@ -35,7 +35,6 @@
         "symfony/config": "^3.2",
         "symfony/translation": "^2.8",
         "symfony/yaml": "~3.2",
-        "vlucas/phpdotenv": "^2.4",
         "php": ">=5.6.0",
         "ext-intl": "*",
         "ext-mbstring": "*",

docs/en/00_Getting_Started/03_Environment_Management.md

@@ -7,8 +7,7 @@ server.
 For each of these environments we may require slightly different configurations for our servers. This could be our debug
 level, caching backends, or - of course - sensitive information such as database credentials.
 
-To solve this problem of setting variables per environment we use environment variables with the help of the 
-[PHPDotEnv](https://github.com/vlucas/phpdotenv) library by Vance Lucas.
+To solve this problem of setting variables per environment we use environment variables, with the help of a `.env` file where this isn't feasible; `.env` is a common concept across many projects of varying languages.
 
 ## Security considerations
 

docs/en/03_Upgrading/index.md

@@ -36,11 +36,11 @@ composer require silverstripe/asset-admin ^1.0
 
 This will also install the `graphql` module for GraphQL API access to your SilverStripe system, which powers the `asset-admin` module.
 
-## Migrate to dotenv
+## Migrate to enviornment variables
 
-SilverStripe 4 requires the use of `.env` and "real" environment variables instead of `_ss_environment.php` for your environment configuration.
+SilverStripe 4 requires the use of environment variables instead of `_ss_environment.php` for your environment configuration. Consult the documentation of your web server to set these per host.
 
-You'll need to move your constants to a new `.env` file before SilverStripe will build successfully.
+If you are unable to set 'true' environment variables, you'll need to move your constants to a new `.env` shim file before SilverStripe will build successfully. Set them in the format `NAME=VALUE`.
 
 If you are not able to move your webserver away from using `_ss_environment.php` files, you can use [this example file](https://gist.github.com/robbieaverill/74fbfff6f438c94f6325107e4d7b2a45) and include it at the top of your `mysite/_config.php` file. This will export your constants as environment variables.
 

src/Core/Environment.php

@@ -23,6 +23,53 @@ class Environment
      */
     protected static $timeLimitMax = null;
 
+    /**
+     * In the case 'true' environment variables cannot be set,
+     * set the appropriate values into the in-memory superglobal.
+     */
+    public static shimFromFile(string $path, string $name = '.env')
+    {
+        $dotEnvFile = $path . DIRECTORY_SEPARATOR . $name;
+        if(is_file($dotEnvFile) && is_readable($dotEnvFile)) {
+            $envVars = file_get_contents($dotEnvFile);
+            //'bash style' comments not valid since php 7.0
+            $envVars = preg_replace('/^#/', ';', $envVars);
+            $envVars = parse_ini_string($envVars);
+            //if the file was invalid $envVars is false and a foreach will error.
+            if (!$envVars) {
+                continue;
+            }
+            foreach ($envVars as $name => $value) {
+                if (!key_exists($name, $_ENV)) {
+                    $_ENV[$name] = $value;
+                }
+                if (!key_exists($name, $_SERVER)) {
+                    $_SERVER[$name] = $value;
+                }
+                putenv("$name=$value");
+                if (function_exists('apache_setenv')) {
+                    apache_setenv($name, $value);
+                }
+                if (!defined($name)) {
+                    define($name, $value);
+                }
+            }
+            break;
+        }
+    }
+
+    /**
+     * Fetch appropriate variable from the environment variables
+     * try first 'true' environment variables, then the $_ENV superglobal
+     *
+     * @param string $name
+     * @return string Values stored in the environment
+     */
+    public static env(string $name)
+    {
+        return getenv($name) ?: $_ENV[$name];
+    }
+
     /**
      * Extract env vars prior to modification
      *

src/includes/constants.php

@@ -1,7 +1,5 @@
 <?php
 
-use Dotenv\Dotenv;
-use Dotenv\Exception\InvalidPathException;
 use SilverStripe\Core\TempFolder;
 
 /**
@@ -61,13 +59,28 @@
 if (!getenv('SS_IGNORE_DOT_ENV')) {
     call_user_func(function () {
         foreach ([BASE_PATH, dirname(BASE_PATH)] as $path) {
-            try {
-                (new Dotenv($path))->load();
-            } catch (InvalidPathException $e) {
-                // no .env found - no big deal
-                continue;
+            $dotEnvFile = $path . DIRECTORY_SEPARATOR . '.env';
+            if(is_file($dotEnvFile) && is_readable($dotEnvFile)) {
+                $envVars = file_get_contents($dotEnvFile);
+                $envVars = preg_replace('/^#/', ';', $envVars);
+                $envVars = parse_ini_string($envVars);
+                //if the file was invalid $envVars is false and a foreach will error.
+                if (!$envVars) {
+                    continue;
+                }
+                foreach ($envVars as $name => $value) {
+                    $_ENV[$name] = $value;
+                    $_SERVER[$name] = $value;
+                    putenv("$name=$value");
+                    if (function_exists('apache_setenv')) {
+                        apache_setenv($name, $value);
+                    }
+                    if (!defined($name)) {
+                        define($name, $value);
+                    }
+                }
+                break;
             }
-            break;
         }
     });
 }