NEW Refactor CLI interaction with Silverstripe app

- Turn sake into a symfony/console app
- Avoid using HTTPRequest for CLI interaction
- Implement abstract hybrid execution path

_config/dev.yml

@@ -2,21 +2,19 @@
 Name: DevelopmentAdmin
 ---
 SilverStripe\Dev\DevelopmentAdmin:
-  registered_controllers:
-    build:
-      controller: SilverStripe\Dev\DevBuildController
-      links:
-        build: 'Build/rebuild this environment. Call this whenever you have updated your project sources'
+  commands:
+    build: 'SilverStripe\Dev\HybridExecution\Command\DevBuild'
+    'build:cleanup': 'SilverStripe\Dev\HybridExecution\Command\DevBuildCleanup'
+    'build:defaults': 'SilverStripe\Dev\HybridExecution\Command\DevBuildDefaults'
+    config: 'SilverStripe\Dev\HybridExecution\Command\DevConfig'
+    'config:audit': 'SilverStripe\Dev\HybridExecution\Command\DevConfigAudit'
+  controllers:
     tasks:
-      controller: SilverStripe\Dev\TaskRunner
-      links:
-        tasks: 'See a list of build tasks to run'
+      class: 'SilverStripe\Dev\TaskRunner'
+      description: 'See a list of build tasks to run'
+  registered_controllers:
     confirm:
       controller: SilverStripe\Dev\DevConfirmationController
-    config:
-      controller: Silverstripe\Dev\DevConfigController
-      links:
-        config: 'View the current config, useful for debugging'
 
 SilverStripe\Dev\CSSContentParser:
   disable_xml_external_entities: true

_config/extensions.yml

@@ -7,6 +7,6 @@ SilverStripe\Security\Member:
 SilverStripe\Security\Group:
   extensions:
     - SilverStripe\Security\InheritedPermissionFlusher
-SilverStripe\ORM\DatabaseAdmin:
+SilverStripe\Dev\HybridExecution\Command\DevBuild:
   extensions:
-    - SilverStripe\Dev\Validation\DatabaseAdminExtension
+    - SilverStripe\Dev\Validation\DevBuildExtension

_config/logging.yml

@@ -52,7 +52,7 @@ Only:
 # Dev handler outputs detailed information including notices
 SilverStripe\Core\Injector\Injector:
   Monolog\Handler\HandlerInterface:
-    class: SilverStripe\Logging\HTTPOutputHandler
+    class: SilverStripe\Logging\ErrorOutputHandler
     constructor:
       - "notice"
     properties:
@@ -66,7 +66,7 @@ Except:
 # CLI errors still show full details
 SilverStripe\Core\Injector\Injector:
   Monolog\Handler\HandlerInterface:
-    class: SilverStripe\Logging\HTTPOutputHandler
+    class: SilverStripe\Logging\ErrorOutputHandler
     constructor:
       - "error"
     properties:

_config/mailer.yml

@@ -6,12 +6,12 @@ SilverStripe\Core\Injector\Injector:
     class: Symfony\Component\Mailer\Mailer
     constructor:
       transport: '%$Symfony\Component\Mailer\Transport\TransportInterface'
-  Symfony\Component\EventDispatcher\EventDispatcherInterface.mailer:
+  Symfony\Contracts\EventDispatcher\EventDispatcherInterface.mailer:
     class: Symfony\Component\EventDispatcher\EventDispatcher
     calls:
       - [addSubscriber, ['%$SilverStripe\Control\Email\MailerSubscriber']]
   Symfony\Component\Mailer\Transport\TransportInterface:
     factory: SilverStripe\Control\Email\TransportFactory
     constructor:
       dsn: 'sendmail://default'
-      dispatcher: '%$Symfony\Component\EventDispatcher\EventDispatcherInterface.mailer'
+      dispatcher: '%$Symfony\Contracts\EventDispatcher\EventDispatcherInterface.mailer'

_config/sake.yml

@@ -0,0 +1,6 @@
+---
+Name: sake-config
+---
+SilverStripe\Core\Injector\Injector:
+  Symfony\Contracts\EventDispatcher\EventDispatcherInterface.sake:
+    class: Symfony\Component\EventDispatcher\EventDispatcher

bin/sake

@@ -0,0 +1,21 @@
+#!/usr/bin/env php
+<?php
+
+use SilverStripe\Cli\Sake;
+
+// Ensure that people can't access this from a web-server
+if (!in_array(PHP_SAPI, ['cli', 'cgi', 'cgi-fcgi'])) {
+    echo 'sake cannot be run from a web request, you have to run it on the command-line.';
+    die();
+}
+
+require_once __DIR__ . '/../src/includes/autoload.php';
+
+$sake = new Sake();
+$sake->addCommands([
+    // probably do this inside the sake app itself though
+    // TODO:
+    //  - flush
+    //  - navigate (use HTTPRequest and spin off a "web" request from CLI)
+]);
+$sake->run();

client/styles/debug.css

@@ -113,7 +113,6 @@ a:active {
 }
 
 /* Content types */
-.build,
 .options,
 .trace {
     position: relative;
@@ -128,19 +127,19 @@ a:active {
     line-height: 1.3;
 }
 
-.build .success {
+.options .success {
     color: #2b6c2d;
 }
 
-.build .error {
+.options .error {
     color: #d30000;
 }
 
-.build .warning {
+.options .warning {
     color: #8a6d3b;
 }
 
-.build .info {
+.options .info {
     color: #0073c1;
 }
 

composer.json

@@ -19,7 +19,7 @@
         }
     ],
     "bin": [
-        "sake"
+        "bin/sake"
     ],
     "require": {
         "php": "^8.3",
@@ -36,12 +36,14 @@
         "psr/container": "^1.1 || ^2.0",
         "psr/http-message": "^1",
         "sebastian/diff": "^4.0",
+        "sensiolabs/ansi-to-html": "^1.2",
         "silverstripe/config": "^3",
         "silverstripe/assets": "^3",
         "silverstripe/vendor-plugin": "^2",
         "sminnee/callbacklist": "^0.1.1",
         "symfony/cache": "^6.1",
         "symfony/config": "^6.1",
+        "symfony/console": "^7.0",
         "symfony/dom-crawler": "^6.1",
         "symfony/filesystem": "^6.1",
         "symfony/http-foundation": "^6.1",
@@ -85,6 +87,7 @@
     },
     "autoload": {
         "psr-4": {
+            "SilverStripe\\Cli\\": "src/Cli/",
             "SilverStripe\\Control\\": "src/Control/",
             "SilverStripe\\Control\\Tests\\": "tests/php/Control/",
             "SilverStripe\\Core\\": "src/Core/",

src/Cli/ArrayCommandLoader.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace SilverStripe\Cli;
+
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\CommandLoader\CommandLoaderInterface;
+use Symfony\Component\Console\Exception\CommandNotFoundException;
+
+/**
+ * Command loader that holds more command loaders
+ */
+class ArrayCommandLoader implements CommandLoaderInterface
+{
+    /**
+     * @var array<CommandLoaderInterface>
+     */
+    private array $loaders = [];
+
+    public function __construct(array $loaders)
+    {
+        $this->loaders = $loaders;
+    }
+
+    public function get(string $name): Command
+    {
+        foreach ($this->loaders as $loader) {
+            if ($loader->has($name)) {
+                return $loader->get($name);
+            }
+        }
+        throw new CommandNotFoundException("Can't find command $name");
+    }
+
+    public function has(string $name): bool
+    {
+        foreach ($this->loaders as $loader) {
+            if ($loader->has($name)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    public function getNames(): array
+    {
+        $names = [];
+        foreach ($this->loaders as $loader) {
+            $names = array_merge($names, $loader->getNames());
+        }
+        return array_unique($names);
+    }
+}

src/Cli/DevCommandLoader.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace SilverStripe\Cli;
+
+use SilverStripe\Dev\DevelopmentAdmin;
+
+/**
+ * Get commands for the controllers registered in DevelopmentAdmin
+ */
+class DevCommandLoader extends HybridCommandLoader
+{
+    protected function getCommands(): array
+    {
+        return DevelopmentAdmin::singleton()->getCommands();
+    }
+}