-
Notifications
You must be signed in to change notification settings - Fork 823
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
API Add AbsoluteLink method to RequestHandler
This is a method that is commonly implemented on controllers, but it really doesn't need to be.
- Loading branch information
1 parent
2c874a1
commit 567484f
Showing
3 changed files
with
119 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
<?php | ||
|
||
namespace SilverStripe\Control\Tests; | ||
|
||
use SilverStripe\Control\Controller; | ||
use SilverStripe\Control\Director; | ||
use SilverStripe\Control\RequestHandler; | ||
use SilverStripe\Dev\SapphireTest; | ||
|
||
/** | ||
* Tests for the RequestHandler class | ||
*/ | ||
class RequestHandlerTest extends SapphireTest | ||
{ | ||
protected $usesDatabase = false; | ||
|
||
public function provideTestLink(): array | ||
{ | ||
return [ | ||
// If there's no url segment, there's no link | ||
[ | ||
'urlSegment' => null, | ||
'action' => null, | ||
'expected' => null, | ||
], | ||
[ | ||
'urlSegment' => null, | ||
'action' => 'some-action', | ||
'expected' => null, | ||
], | ||
// The action is just addeed on after the url segment | ||
[ | ||
'urlSegment' => 'my-controller', | ||
'action' => null, | ||
'expected' => 'my-controller', | ||
], | ||
[ | ||
'urlSegment' => 'my-controller', | ||
'action' => 'some-action', | ||
'expected' => 'my-controller/some-action', | ||
], | ||
]; | ||
} | ||
|
||
/** | ||
* @dataProvider provideTestLink | ||
*/ | ||
public function testLink(?string $urlSegment, ?string $action, ?string $expected) | ||
{ | ||
if ($urlSegment === null) { | ||
$this->expectWarning(); | ||
$this->expectWarningMessage('Request handler SilverStripe\Control\RequestHandler does not have a url_segment defined. Relying on this link may be an application error'); | ||
} | ||
|
||
$handler = new RequestHandler(); | ||
RequestHandler::config()->set('url_segment', $urlSegment); | ||
Controller::config()->set('add_trailing_slash', false); | ||
|
||
$this->assertEquals($expected, $handler->Link($action)); | ||
|
||
// Validate that trailing slash config is respected | ||
Controller::config()->set('add_trailing_slash', true); | ||
if (is_string($expected)) { | ||
$expected .= '/'; | ||
} | ||
|
||
$this->assertEquals($expected, $handler->Link($action)); | ||
} | ||
|
||
/** | ||
* @dataProvider provideTestLink | ||
*/ | ||
public function testAbsoluteLink(?string $urlSegment, ?string $action, ?string $expected) | ||
{ | ||
if ($urlSegment === null) { | ||
$this->expectWarning(); | ||
$this->expectWarningMessage('Request handler SilverStripe\Control\RequestHandler does not have a url_segment defined. Relying on this link may be an application error'); | ||
} | ||
|
||
$handler = new RequestHandler(); | ||
RequestHandler::config()->set('url_segment', $urlSegment); | ||
Controller::config()->set('add_trailing_slash', false); | ||
|
||
if ($expected !== null) { | ||
$expected = Director::absoluteURL($expected); | ||
} | ||
$this->assertEquals($expected, $handler->AbsoluteLink($action)); | ||
|
||
// Validate that trailing slash config is respected | ||
Controller::config()->set('add_trailing_slash', true); | ||
if (is_string($expected)) { | ||
$expected = Director::absoluteURL($expected . '/'); | ||
} | ||
|
||
$this->assertEquals(Director::absoluteURL($expected), $handler->AbsoluteLink($action)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters