Merge pull request #10456 from creative-commoners/pulls/5/rescue-mast…

…er-remove-unsafe-queryparams

API Rescue Master Branch PR: Remove isDev / isTest querystring arguments

src/Core/BaseKernel.php

@@ -257,12 +257,6 @@ public function getEnvironment()
             return $this->enviroment;
         }
 
-        // Check saved session
-        $env = $this->sessionEnvironment();
-        if ($env) {
-            return $env;
-        }
-
         // Check getenv
         if ($env = Environment::getEnv('SS_ENVIRONMENT_TYPE')) {
             return $env;
@@ -271,23 +265,6 @@ public function getEnvironment()
         return self::LIVE;
     }
 
-    /**
-     * Check or update any temporary environment specified in the session.
-     *
-     * @return null|string
-     *
-     * @deprecated 5.0 Use Director::get_session_environment_type() instead
-     */
-    protected function sessionEnvironment()
-    {
-        if (!$this->booted) {
-            // session is not initialyzed yet, neither is manifest
-            return null;
-        }
-
-        return Director::get_session_environment_type();
-    }
-
     abstract public function boot($flush = false);
 
     abstract public function isFlushed();

src/Core/Startup/ErrorControlChainMiddleware.php

@@ -53,10 +53,7 @@ protected function prepareConfirmationTokenChain(HTTPRequest $request)
     {
         $chain = new ConfirmationTokenChain();
         $chain->pushToken(new URLConfirmationToken('dev/build', $request));
-
-        foreach (['isTest', 'isDev', 'flush'] as $parameter) {
-            $chain->pushToken(new ParameterConfirmationToken($parameter, $request));
-        }
+        $chain->pushToken(new ParameterConfirmationToken('flush', $request));
 
         return $chain;
     }

src/Core/Startup/ParameterConfirmationToken.php

@@ -129,7 +129,6 @@ public function reloadRequiredIfError()
 
     public function suppress()
     {
-        unset($_GET[$this->parameterName]);
         $this->request->offsetUnset($this->parameterName);
     }