Merge branch '4.7' into 4

silverstripe · Mar 1, 2021 · 2c54a3f · 2c54a3f
2 parents 229672a + 705b746
commit 2c54a3f
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 24 deletions.
diff --git a/src/View/Parsers/ShortcodeParser.php b/src/View/Parsers/ShortcodeParser.php
@@ -263,8 +263,8 @@ protected function insertListAfter($new, $after)
 		([^\s\/\'"=,]+)       # Name
 		\s* = \s*
 		(?:
-			(?:\'([^\']+)\') | # Value surrounded by \'
-			(?:"([^"]+)")    | # Value surrounded by "
+			(?:\'([^\']*)\') | # Value surrounded by \'
+			(?:"([^"]*)")    | # Value surrounded by "
 			([^\s,\]]+)          # Bare value
 		)
 ';

diff --git a/tests/php/View/Parsers/ShortcodeParserTest.php b/tests/php/View/Parsers/ShortcodeParserTest.php
@@ -79,37 +79,54 @@ public function testNotRegisteredShortcode()
         );
     }
 
-    public function testSimpleTag()
+    public function simpleTagDataProvider()
     {
-        $tests = [
-            '[test_shortcode]',
-            '[test_shortcode ]', '[test_shortcode,]', '[test_shortcode, ]' . '[test_shortcode/]', '[test_shortcode /]', '[test_shortcode,/]', '[test_shortcode, /]'
+        return [
+            ['[test_shortcode]'],
+            ['[test_shortcode ]'],
+            ['[test_shortcode,]'],
+            ['[test_shortcode, ][test_shortcode/]'],
+            ['[test_shortcode /]'],
+            ['[test_shortcode,/]'],
+            ['[test_shortcode, /]']
         ];
+    }
 
-        foreach ($tests as $test) {
-            $this->parser->parse($test);
-
-            $this->assertEquals([], $this->arguments, $test);
-            $this->assertEquals('', $this->contents, $test);
-            $this->assertEquals('test_shortcode', $this->tagName, $test);
-        }
+    /**
+     * @dataProvider simpleTagDataProvider
+     */
+    public function testSimpleTag($test)
+    {
+        $this->parser->parse($test);
+        $this->assertEquals([], $this->arguments, $test);
+        $this->assertEquals('', $this->contents, $test);
+        $this->assertEquals('test_shortcode', $this->tagName, $test);
     }
 
-    public function testOneArgument()
+    public function oneArgumentDataProvider()
     {
-        $tests =  [
-            '[test_shortcode foo="bar"]', '[test_shortcode,foo="bar"]',
-            "[test_shortcode foo='bar']", "[test_shortcode,foo='bar']",
-            '[test_shortcode  foo  =  "bar"  /]', '[test_shortcode,  foo  =  "bar"  /]'
+        return [
+            ['[test_shortcode foo="bar"]'],
+            ['[test_shortcode,foo="bar"]'],
+            ["[test_shortcode foo='bar']"],
+            ["[test_shortcode,foo='bar']"],
+            ["[test_shortcode foo=bar]"],
+            ["[test_shortcode,foo=bar]"],
+            ['[test_shortcode  foo  =  "bar"  /]'],
+            ['[test_shortcode,  foo  =  "bar"  /]']
         ];
+    }
 
-        foreach ($tests as $test) {
-            $this->parser->parse($test);
+    /**
+     * @dataProvider oneArgumentDataProvider
+     */
+    public function testOneArgument($test)
+    {
+        $this->parser->parse($test);
 
-            $this->assertEquals(['foo' => 'bar'], $this->arguments, $test);
-            $this->assertEquals('', $this->contents, $test);
-            $this->assertEquals('test_shortcode', $this->tagName, $test);
-        }
+        $this->assertEquals(['foo' => 'bar'], $this->arguments, $test);
+        $this->assertEquals('', $this->contents, $test);
+        $this->assertEquals('test_shortcode', $this->tagName, $test);
     }
 
     public function testMultipleArguments()
@@ -121,6 +138,26 @@ public function testMultipleArguments()
         $this->assertEquals('test_shortcode', $this->tagName);
     }
 
+    public function emptyArgumentsDataProvider()
+    {
+        return [
+            ['[test_shortcode foo=""]'],
+            ['[test_shortcode,foo=\'\']'],
+            ['[test_shortcode foo=""][/test_shortcode]'],
+        ];
+    }
+
+    /**
+     * @dataProvider emptyArgumentsDataProvider
+     */
+    public function testEmptyArguments($test)
+    {
+        $this->parser->parse($test);
+        $this->assertEquals(['foo' => ''], $this->arguments);
+        $this->assertEquals('', $this->contents);
+        $this->assertEquals('test_shortcode', $this->tagName);
+    }
+
     public function testEnclosing()
     {
         $this->parser->parse('[test_shortcode]foo[/test_shortcode]');