Merge pull request #10894 from lekoala/patch-43

Ensure cache key only contains valid characters
silverstripe · Aug 3, 2023 · 0e74e35 · 0e74e35
2 parents 6ed50b5 + 0e839e1
commit 0e74e35
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Core/Manifest/VersionProvider.php b/src/Core/Manifest/VersionProvider.php
@@ -44,7 +44,7 @@ class VersionProvider
      */
     public function getVersion()
     {
-        $key = sprintf('%s-%s', $this->getComposerLockPath(), 'all');
+        $key = preg_replace("/[^A-Za-z0-9]/", '_', $this->getComposerLockPath() . '_all');
         $version = $this->getCachedValue($key);
         if ($version) {
             return $version;
@@ -80,7 +80,7 @@ public function getVersion()
      */
     public function getModuleVersion(string $module): string
     {
-        $key = sprintf('%s-%s', $this->getComposerLockPath(), $module);
+        $key = preg_replace("/[^A-Za-z0-9]/", '_', $this->getComposerLockPath() . '_' . $module);
         $version = $this->getCachedValue($key);
         if ($version) {
             return $version;